SDL_sound: rename to SDL2_sound #5
Conversation
Renamed so it can be installed alongside vanilla SDL_sound without file conflicts Signed-off-by: Marty Plummer <[email protected]>
|
Why do you need to have both installed? By "file conflicts", are you talking about vanilla SDL_sound from the distro repository, or manually compiled? |
|
I mean from distro repos. I don't know for a fact that anyone would ever need both installed in 'system' at the same time, but I know if it were tried it would either not work due to a smart package manager or clobber an existing vanilla SDL_sound install if manually compiled/installed with --prefix=/usr. |
That's the reason why the default is I feel like this rename would be fine if we heavily cleaned up the codebase, rewrote the automake scripts to be modern etc., or actually broke the SDL_sound API for some reason. But right now, this change will just lead to mkxp not building with this fork anymore. If I adjust mkxp as well, then everyone will have to update their SDL_sound installation for no reason at all. It doesn't make sense to me to have this in the public repo at the moment, maybe in the future. |
|
I was actually going to look into fixing up the buildscripts a bit. Possibly replace it with something less arcane to begin with. mesonbuild is very nice, I've managed to write up a build for mkxp with it that works for linux and windows. |
|
@hanetzer @Ancurio sorry for hijacking, but it current SDL_sound version compatible with legacy SDL 1.2.x? 86ec51c broke the ability to build on that particular setup, forcing a hard requirement of SDL 2.0, albeit by changing the requirements by hand I was still able to get the lib to build properly. OTOH, the main docs still say that
IMVHO, it's either a bug in config, an outdated doc/readme, or both. I've been able to compile DOSBox SVN with SDL 1.2 & bleeding edge SDL_sound, and the results are OK, at least for the WAV decoder. |
|
@FyiurAmron I can't think of any reason why you'd want my modified SDL_sound together with SDL 1.2 dependent projects. SDL 1.2 is deprecated and should never be used for any purposes aside time travelling. |
|
@Ancurio After thinking about what you said - I can say that I can't think of any reason to use your fork of SDL_sound at all. Thanks for the response, it was certainly insightful. |
|
@FyiurAmron yeah, sorry about the confusion. This fork has some fixes / features that are only relevant to mkxp, and the original developer won't merge changes (he abandoned the project). |
|
Well, this could also be renamed |
|
@Ancurio by "orginal developer", do you mean @rcgordon (i.e. Icculus)? If so, he hasn't "abandoned" SDL_sound - he had a hiatus from 2012 to 2017, but the code is most certainly maintained, even if not extremely actively (last batch of commits is from 11 months ago) |
|
@FyiurAmron Yes, I mean icculus. Some time ago I wrote an email to him asking him about SDL_sound's future and possible plans for an SDL2 conversion, but never got an answer, so I assumed he wasn't interested. @carstene1ns well, I think if you want to use SDL_sound in an SDL2 codebase, this fork is still going to work better than the main branch; and ideally, this project should morph into "SDL2_sound" one day. |
|
Fwiw, my tree is pushing towards a rewrite for a 2.0 release. It isn't done yet, but a lot of modernization has happened in there: https://www.patreon.com/posts/project-sdl-2-0-20211701 |
|
@rcgordon That's great to hear, I was pretty busy the last couple of years so I'm sad I missed this. Once that effort is under way, I will be pushing for the inclusion of all my changes and then this fork can hopefully be shut down. |
Renamed so it can be installed alongside vanilla SDL_sound without file
conflicts
Signed-off-by: Marty Plummer [email protected]