refactor: Rename consts to specifically specify Titanfall2 #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Renames `TITANFALL_STEAM_ID` to `TITANFALL2_STEAM_ID` `TITANFALL_ORIGIN_IDS` to `TITANFALL2_ORIGIN_IDS`
|
Changed the variable names by just doing a global search and replace btw ^^ |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10 +/- ##
=======================================
Coverage 87.26% 87.26%
=======================================
Files 5 5
Lines 903 903
=======================================
Hits 788 788
Misses 115 115 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renames
TITANFALL_STEAM_IDtoTITANFALL2_STEAM_IDTITANFALL_ORIGIN_IDStoTITANFALL2_ORIGIN_IDSThis is done as
Titanfalltechnically implies the first game which is also on Steam and Origin. I'm aware thatlibthermiteonly targets Titanfall2 but just adding a2to the variable name doesn't really increase the name length while helping a lot with proper namespacing ^^Would technically require a major version bump on release due to the current interface already being public.