fix issues brought up by coderabbit

AmruthPillai · Jan 11, 2025 · 3b73dcf · 3b73dcf
1 parent 9b20c46
commit 3b73dcf
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/apps/client/src/libs/lingui.ts b/apps/client/src/libs/lingui.ts
@@ -17,8 +17,8 @@ export async function dynamicActivate(locale: string) {
     if (dayjsLocales[locale]) {
       dayjs.locale(await dayjsLocales[locale]());
     }
-  } catch (error) {
-    // eslint-disable-next-line no-console
-    console.error(error);
+  } catch {
+    // eslint-disable-next-line lingui/no-unlocalized-strings
+    throw new Error(`Failed to load messages for locale: ${locale}`);
   }
 }
diff --git a/apps/server/src/printer/printer.service.ts b/apps/server/src/printer/printer.service.ts
@@ -204,8 +204,10 @@ export class PrinterService {
 
       return resumeUrl;
     } catch (error) {
-      // eslint-disable-next-line no-console
-      console.trace(error);
+      throw new InternalServerErrorException(
+        ErrorMessage.ResumePrinterError,
+        (error as Error).message,
+      );
     }
   }