Ternary vs conditional sections rebase #147
Conversation
|
@devmanhinton I think this is good now, or make that other word choice change you suggested maybe? or I can, forgot you put in chat. |
| alias: 'IronMan' | ||
| availability: ['10am', '2pm'] | ||
| alias: 'IronMan', | ||
| available: false |
There was a problem hiding this comment.
Is 'alias' used at all? :) How about firstName & lastName, can we just make it name: 'Tony Stark' :)
There was a problem hiding this comment.
can tweak that in another PR I think, or edit it here yourself if you really want, I don't care too much :-)
|
If you are fine with that change. I am happy to merge :) |
| ```html | ||
| <div class="user-"> | ||
| <p> | ||
| My schedule is very full. |
There was a problem hiding this comment.
I just noticed this is not the html that it outputs... it outputs My schedule is very full. <span class="isAvailable-" style="display:none">I just have a few openings</span> in the p tag... if we're still showing complete markup generated... @yaymukund do you think it's clearer not displaying that here?
There was a problem hiding this comment.
No, I think it's important we show the actual markup that's generated. As I've said before, my original intention was to turn all the examples in docs to example files so they'd be easily tested and match exactly the output.
|
@bglusman What are we doing with this? If its outdate can you close this PR |
|
Sorry hadn't seen, i think this should still be fixed and merged with On Thursday, November 14, 2013, Devon Hinton wrote:
Brian Glusman - [email protected] |
|
@devmanhinton still like to merge this in, unless you have any objections. |
|
👍 on this. Was there any objection? |
| ```html | ||
| <div class="user-"> | ||
| <p> | ||
| My schedule is very full. <span class="isAvailable-" style="display:none">I just have a few openings</span> |
There was a problem hiding this comment.
Does this need style="display:none;"? I feel like class="isAvailable-" should do it for you.
There was a problem hiding this comment.
this is the output it's what enddash renders.
Rebase in favor of #132