Feature/refactor customers page #897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
palbock
requested changes
Oct 10, 2024
| } | ||
|
|
||
| private void ResetCustomerToOriginalValues(object? customer) | ||
| private void FilterCustomers() |
There was a problem hiding this comment.
Kan den gamle FilterCustomer-metoden fjernes?
There was a problem hiding this comment.
godt fanget opp. den skal bort. fikser.
|
|
||
| private async Task CustomerChangeCommitted() | ||
| private void NavigateToCustomer(int customerId) |
There was a problem hiding this comment.
Brukes denne metoden lenger?
There was a problem hiding this comment.
planen er å bruke den straks.
| [Parameter] public RenderFragment? CustomerCardAvatarImage { get; set; } | ||
| [Parameter] public EventCallback OnActionPress { get; set; } | ||
| [Parameter] public string ActionLabel { get; set; } = ""; | ||
| [Parameter] public string? AvatarImageUrl { get; set; } |
There was a problem hiding this comment.
Regner med at flere av disse parameterene er tenkt til å tas i bruk senere?
palbock
reviewed
Oct 10, 2024
There was a problem hiding this comment.
Burde denne renames til CustomerAdminResponse?
There was a problem hiding this comment.
Absolutt et bedre navn.
palbock
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
customers_page.mp4