Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add tfc compat and addons #69

Merged
merged 5 commits into from
Mar 1, 2024
Merged

add tfc compat and addons #69

merged 5 commits into from
Mar 1, 2024

Conversation

pietro-lopes
Copy link

Issue Reference

Add TFC compat and their addons

@rlnt
Copy link
Member

rlnt commented Feb 28, 2024 •
edited
Loading

Edit: I fixed it, god bless

Thank you for the pull request. I'll take a look at it when I find the time.

Don't be confused about the build workflow failing. There is a Java bug at the moment which prevents the build from succeeding although the mentioned code is valid. Reference: https://bugs.openjdk.org/browse/JDK-8324860?jql=text%20~%20%22inferred%20type%22%20ORDER%20BY%20created%20DESC

I sadly can't work around this right now since all JDK distributions seem to have the same issue right now.

@rlnt rlnt force-pushed the 1.20.1-tfc-compat branch from 0e3911a to 310f09f Compare March 1, 2024 20:03
@rlnt rlnt merged commit 7ff762b into AlmostReliable:1.20.1 Mar 1, 2024
1 check passed
@rlnt rlnt mentioned this pull request Aug 22, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pietro-lopes @rlnt