Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes to Credit Assignment replication notebook. #359

Merged
merged 3 commits into from
Mar 6, 2024

Conversation

colleenjg
Copy link
Contributor

  • Fixed typos and textual errors in the Credit Assignment replication notebook.
  • Fixed import statement:
    • import cred_assign_utils -> from databook_utils import cred_assign_utils.
    • Now works on Google Colab, in Binder, and locally.
  • Minor changes to references.bib:
    • Added volume and number to Gillon2023 and Gillon2024.
    • Changed capitalization of journal names in two entries, to be consistent across entries.

Corrected cred_assign_utils import statement.
Updated data directory path to accommodate running from the local directory or the main directory.
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Minor fix to journal capitalization for consistency across publications.
@colleenjg
Copy link
Contributor Author

Force pushes were to fix minor formatting errors I introduced in references.bib with my initial PR.

Added additional possible paths to data dictionaries so that notebook can run on Google Colab.
@rcpeene rcpeene changed the base branch from main to dev March 6, 2024 22:22
@rcpeene rcpeene merged commit e441944 into AllenInstitute:dev Mar 6, 2024
1 of 2 checks passed
@colleenjg colleenjg deleted the cred_assign_data branch March 11, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants