Specifying Y-direction for FilterNet #394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also added a function to flip y when movies are imported.
y_dir == 'down' is default, but 'up' should be used when LGN coordinate is defined as 'azimuth' and 'elevation', the way the new V1 model defines.
'graiting' is changed to 'grating'
('graiting' will still work.)
kaeldai
reviewed
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added a new feature in BMTK to be compatible with the LGN of the new V1 model that has Y-axis defined upward. Currently, BMTK uses the downward Y-axis implicitly, while defining the angle of the drifting gratings using upward Y-axis. This may cause confusion, so I tried to make it more optional and explicit.
I did not change the default behavior, but implemented the 'y_dir' option, and the generation of the drifting gratings respect this option. Also, when movie is imported to BMTK, it can be optionally flipped along the Y-axis to resolve compatibility between the typical image format that uses the downward Y-axis and the new LGN model that uses the upward Y-axis.
A few tests were added for these changes and the documentation was updated.
Also, I've fixed a strange behavior of the 'add_movie' method for 'movie' option and 'data_file' is not specified. This method was supposed to work when 'data' was specified instead of 'data_file', but it wasn't.
On the minor thing, the spelling error for 'grating' was fixed on the examples in BMTK, and FilterNet is now compatible with both 'grating' and 'grating' for backward compatibility.