Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following changes are made in
bmtk/simulator/filternet/lgnmodel/fitfuns.py
to significantly speed up network preparation:ff()
to use vectorized computation instead of looping over an NumPy array.np.tile
in functionnormalizecols()
andmakeBasis_StimKernel()
by automatic broadcasting in NumPy.makeBasis_StimKernel()
, compute variablekbasis0
in a single step instead of using a for-loop in original code.