Fix macOS build by pinning delocate
#706
Conversation
The default shell invocation in GitHub actions sets the `-e` flag, which causes the job to
be aborted as soon as any command exits with a non-zero code. By overriding the shell
with `zsh {0}` we had disabled this behavior, which meant the failure of `delocate-fuse`
was not reported properly.
Ideally we'd upgrade to delocate 0.12.0 and use the new delocate-merge command, but it fails on numpy (matthew-brett/delocate#227), so we'll stick to 0.11.0 for now.
WalkthroughThe changes in this pull request involve modifying the installation command for the Changes
Assessment against linked issues
Possibly related PRs
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- .github/workflows/build-multi-os.yml (1 hunks)
Additional comments not posted (1)
.github/workflows/build-multi-os.yml (1)
316-316: Pindelocateto version0.11.0to fix macOS build issues.The change to pin the
delocateversion to0.11.0is crucial for maintaining the build process stability on macOS, given the breaking changes introduced indelocateversion0.12.0. This modification aligns with the PR's objective to address the macOS build failure documented in issue #704.
- Correctness: The syntax for specifying the version is correct (
delocate==0.11.0).- Compatibility: Pinning the version ensures compatibility with the current build scripts and avoids the deprecated
delocate-fusecommand.- Future Considerations: It's important to plan for an eventual upgrade to newer versions of
delocateonce compatibility issues with other dependencies likenumpyare resolved.
Fixes #704 by pinning the version of the
delocatetool we use to create universal Python wheels of dependencies.It turns out
delocatereleased a new release (0.12.0) on August 29th. There's a breaking change in that release: thedelocate-fusecommand that our build uses is now hard-deprecated and fails with an error message.Ideally we'd upgrade to
delocate0.12.0and use the newdelocate-mergecommand, but it fails onnumpy(see matthew-brett/delocate#227), so we'll stick to0.11.0for now.Proof that this fixes the macOS build: https://github.com/jonathanperret/ayab-desktop/actions/runs/10763703517/job/29845535528
Summary by CodeRabbit
delocatepackage to a specific version for improved stability in the workflow.