Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix success comment detection in github-api.ts #21

Merged
merged 11 commits into from
Dec 3, 2024

Conversation

neubig
Copy link
Contributor

@neubig neubig commented Dec 3, 2024

This PR fixes an issue where success comments were not being properly detected in the github-api.ts file. The problem was that the string matching for success comments was too strict and did not properly handle the case where a PR was created.

Changes:

  • Modified isSuccessComment to detect PR creation success comments by using a more flexible string match
  • Added tests to verify comment detection behavior
  • Fixed async cleanup issues in tests

Tested:

  • Added unit tests for comment detection
  • Manually verified that the cache is now properly built with success comments from issues #5363 and #5343

* Modify isSuccessComment to detect PR creation success comments
* Add tests to verify comment detection behavior
* Fix async cleanup issues in tests
Copy link

vercel bot commented Dec 3, 2024

@openhands-agent is attempting to deploy a commit to the all-hands-ai team on Vercel, but is not a member of this team. To resolve this issue, you can:

  • Make your repository public. Collaboration is free for open source and public repositories.
  • Add @openhands-agent as a member. A Pro subscription is required to access Vercel's collaborative features.
    • If you're the owner of the team, click here and add @openhands-agent as a member.
    • If you're the user who initiated this build request, click here to request access.
    • If you're already a member of the all-hands-ai team, make sure that your Vercel account is connected to your GitHub account.

To read more about collaboration on Vercel, click here.

* Modify isSuccessComment to detect PR creation success comments
* Add tests to verify comment detection behavior
* Fix async cleanup issues in tests
* Modify isSuccessComment to detect PR creation success comments
* Add tests to verify comment detection behavior
* Fix test configuration and remove unnecessary complexity
* Add type: module to package.json to fix ESLint module loading
* Move tests to test/ directory
* Fix vitest configuration
* Fix build configuration
* Convert PostCSS config to CommonJS format
* Rename PostCSS config to .js
* Fix vitest configuration to work with vite plugins
* Fix PostCSS configuration to work with ESM
* Update ESLint configuration to include test directory
* Update TypeScript configuration to include test directory
* Fix TypeScript configuration to work with vitest
* Add vitest types to all tsconfig files
* Fix vitest configuration to work with TypeScript
@neubig neubig force-pushed the fix-success-comment-detection branch from 7116171 to 20978d5 Compare December 3, 2024 15:13
@neubig neubig merged commit a16e240 into main Dec 3, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants