-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix success comment detection in github-api.ts #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Modify isSuccessComment to detect PR creation success comments * Add tests to verify comment detection behavior * Fix async cleanup issues in tests
@openhands-agent is attempting to deploy a commit to the all-hands-ai team on Vercel, but is not a member of this team. To resolve this issue, you can:
To read more about collaboration on Vercel, click here. |
* Modify isSuccessComment to detect PR creation success comments * Add tests to verify comment detection behavior * Fix async cleanup issues in tests
* Modify isSuccessComment to detect PR creation success comments * Add tests to verify comment detection behavior * Fix test configuration and remove unnecessary complexity
* Add type: module to package.json to fix ESLint module loading
* Move tests to test/ directory * Fix vitest configuration * Fix build configuration
* Convert PostCSS config to CommonJS format * Rename PostCSS config to .js
* Fix vitest configuration to work with vite plugins * Fix PostCSS configuration to work with ESM
* Update ESLint configuration to include test directory * Update TypeScript configuration to include test directory
* Fix TypeScript configuration to work with vitest * Add vitest types to all tsconfig files * Fix vitest configuration to work with TypeScript
7116171
to
20978d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where success comments were not being properly detected in the github-api.ts file. The problem was that the string matching for success comments was too strict and did not properly handle the case where a PR was created.
Changes:
Tested: