Fix lint and type errors

All-Hands-AI · Dec 10, 2024 · 608f1f7 · 608f1f7
1 parent ec0be4a
commit 608f1f7
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 7 deletions.
diff --git a/scripts/src/github-api.ts b/scripts/src/github-api.ts
@@ -57,7 +57,7 @@ async function fetchAllPages<T>(url: string): Promise<T[]> {
     pageCount++;
     console.log(`Fetching page ${pageCount.toString()} from ${currentUrl}`);
     const response = await fetchWithAuth(currentUrl);
-    console.log(`Got ${response.data.length.toString()} items`);
+    console.log(`Got ${String(response.data.length)} items`);
     allItems.push(...(response.data as T[]));
     currentUrl = response.nextUrl ?? '';
   }
@@ -155,7 +155,7 @@ async function processIssueComments(issue: GitHubIssue): Promise<Activity[]> {
           let prNumber: string | undefined;
 
           // Try full PR URL format
-          const fullUrlMatch = successComment.body.match(/https:\/\/github\.com\/[^\/]+\/[^\/]+\/pull\/(\d+)/);
+          const fullUrlMatch = successComment.body.match(/https:\/\/github\.com\/[^/]+\/[^/]+\/pull\/(\d+)/);
           if (fullUrlMatch) {
             prNumber = fullUrlMatch[1];
           }

diff --git a/scripts/src/types.ts b/scripts/src/types.ts
@@ -34,7 +34,7 @@ export interface GitHubPRResponse {
 }
 
 export interface ApiResponse {
-  data: any[] | any;
+  data: unknown[];
   hasNextPage: boolean;
   nextUrl: string | null;
 }

diff --git a/src/__integration_tests__/github.test.ts b/src/__integration_tests__/github.test.ts
@@ -58,6 +58,7 @@ describe('GitHub Service Integration Tests', () => {
       url: expect.stringMatching(/^https:\/\/github\.com\//),
       title: expect.any(String),
       description: expect.any(String),
+      prUrl: expect.any(String),
     };
 
     for (const activity of activities) {

diff --git a/src/components/ActivityList.test.tsx b/src/components/ActivityList.test.tsx
@@ -1,5 +1,5 @@
 import { render, screen, fireEvent } from '@testing-library/react';
-import { describe, it, expect, beforeEach } from 'vitest';
+import { describe, it, expect, beforeEach, afterEach } from 'vitest';
 import { ActivityList } from './ActivityList';
 import { BotActivity } from '../types';
 import { getComputedStyle } from '../test/testUtils';
@@ -137,7 +137,7 @@ describe('ActivityList', () => {
     afterEach(() => {
       // Clean up styles
       const styles = document.head.getElementsByTagName('style');
-      Array.from(styles).forEach(style => style.remove());
+      Array.from(styles).forEach((style) => { style.remove(); });
     });
 
     const issueStatuses = [
@@ -248,7 +248,7 @@ describe('ActivityList', () => {
     afterEach(() => {
       // Clean up styles
       const styles = document.head.getElementsByTagName('style');
-      Array.from(styles).forEach(style => style.remove());
+      Array.from(styles).forEach((style) => { style.remove(); });
     });
 
     describe('pagination styling', () => {

diff --git a/src/components/ActivityList.tsx b/src/components/ActivityList.tsx
@@ -1,4 +1,4 @@
-import { BotActivity, IssueActivityStatus } from '../types';
+import { BotActivity } from '../types';
 import { useState } from 'react';
 
 interface ActivityListProps {