Fix all linting issues

All-Hands-AI · Nov 28, 2024 · 1acc206 · 1acc206
1 parent 3c6a7e4
commit 1acc206
Show file tree

Hide file tree

Showing 10 changed files with 31 additions and 24 deletions.
diff --git a/src/App.tsx b/src/App.tsx
@@ -9,7 +9,7 @@ import { ActivityFilter as FilterType, DateRange, AppState } from './types';
 import { fetchBotActivities } from './services/github';
 import './App.css';
 
-function App(): JSX.Element {
+function App(): React.JSX.Element {
   const [state, setState] = useState<AppState>({
     activities: [],
     loading: true,
@@ -82,9 +82,9 @@ function App(): JSX.Element {
         />
       </section>
 
-      {state.loading ? (
+      {state.loading === true ? (
         <LoadingSpinner />
-      ) : state.error ? (
+      ) : state.error !== null ? (
         <ErrorMessage
           message={state.error}
           onRetry={handleRetry}

diff --git a/src/components/ActivityChart.tsx b/src/components/ActivityChart.tsx
@@ -8,7 +8,7 @@ interface ActivityChartProps {
   type: ActivityType;
 }
 
-export function ActivityChart({ activities, type }: ActivityChartProps): JSX.Element {
+export function ActivityChart({ activities, type }: ActivityChartProps): React.JSX.Element {
   const spec: VisualizationSpec = useMemo(() => ({
     $schema: 'https://vega.github.io/schema/vega-lite/v5.json',
     data: {

diff --git a/src/components/ActivityFilter.tsx b/src/components/ActivityFilter.tsx
@@ -5,7 +5,7 @@ interface ActivityFilterProps {
   onFilterChange: (filter: FilterType) => void;
 }
 
-export function ActivityFilter({ filter, onFilterChange }: ActivityFilterProps): JSX.Element {
+export function ActivityFilter({ filter, onFilterChange }: ActivityFilterProps): React.JSX.Element {
   const handleTypeChange = (type: ActivityType | ''): void => {
     onFilterChange({
       ...filter,

diff --git a/src/components/ActivityList.tsx b/src/components/ActivityList.tsx
@@ -4,7 +4,7 @@ interface ActivityListProps {
   activities: BotActivity[];
 }
 
-export function ActivityList({ activities }: ActivityListProps): JSX.Element {
+export function ActivityList({ activities }: ActivityListProps): React.JSX.Element {
   return (
     <div className="activity-list">
       {activities.map((activity) => (

diff --git a/src/components/DateRangeFilter.test.tsx b/src/components/DateRangeFilter.test.tsx
@@ -22,8 +22,8 @@ describe('DateRangeFilter', () => {
       />
     );
 
-    const startInput = screen.getByLabelText('From:') as HTMLInputElement;
-    const endInput = screen.getByLabelText('To:') as HTMLInputElement;
+    const startInput = screen.getByLabelText<HTMLInputElement>('From:');
+    const endInput = screen.getByLabelText<HTMLInputElement>('To:');
 
     expect(startInput.value).toBe('2023-11-01');
     expect(endInput.value).toBe('2023-11-30');

diff --git a/src/components/DateRangeFilter.tsx b/src/components/DateRangeFilter.tsx
@@ -5,39 +5,41 @@ interface DateRangeFilterProps {
   onDateRangeChange: (dateRange?: DateRange) => void;
 }
 
-export function DateRangeFilter({ dateRange, onDateRangeChange }: DateRangeFilterProps) {
-  const handleStartDateChange = (event: React.ChangeEvent<HTMLInputElement>) => {
+export function DateRangeFilter({ dateRange, onDateRangeChange }: DateRangeFilterProps): React.JSX.Element {
+  const handleStartDateChange = (event: React.ChangeEvent<HTMLInputElement>): void => {
     const start = event.target.value;
-    const end = dateRange?.end || '';
+    const end = dateRange?.end ?? '';
 
-    if (!start && !end) {
+    if (start === '' && end === '') {
       onDateRangeChange(undefined);
     } else {
       onDateRangeChange({ start, end });
     }
   };
 
-  const handleEndDateChange = (event: React.ChangeEvent<HTMLInputElement>) => {
+  const handleEndDateChange = (event: React.ChangeEvent<HTMLInputElement>): void => {
     const end = event.target.value;
-    const start = dateRange?.start || '';
+    const start = dateRange?.start ?? '';
 
-    if (!end && !start) {
+    if (end === '' && start === '') {
       onDateRangeChange(undefined);
     } else {
       onDateRangeChange({ start, end });
     }
   };
 
+  const maxDate = new Date().toISOString().split('T')[0];
+
   return (
     <div className="date-range-filter">
       <div className="filter-group">
         <label htmlFor="start-date">From:</label>
         <input
           type="date"
           id="start-date"
-          value={dateRange?.start || ''}
+          value={dateRange?.start ?? ''}
           onChange={handleStartDateChange}
-          max={new Date().toISOString().split('T')[0]}
+          max={maxDate}
         />
       </div>
 
@@ -46,9 +48,9 @@ export function DateRangeFilter({ dateRange, onDateRangeChange }: DateRangeFilte
         <input
           type="date"
           id="end-date"
-          value={dateRange?.end || ''}
+          value={dateRange?.end ?? ''}
           onChange={handleEndDateChange}
-          max={new Date().toISOString().split('T')[0]}
+          max={maxDate}
         />
       </div>
     </div>

diff --git a/src/components/ErrorMessage.tsx b/src/components/ErrorMessage.tsx
@@ -3,7 +3,7 @@ interface ErrorMessageProps {
   onRetry: () => void;
 }
 
-export function ErrorMessage({ message, onRetry }: ErrorMessageProps): JSX.Element {
+export function ErrorMessage({ message, onRetry }: ErrorMessageProps): React.JSX.Element {
   return (
     <div className="error-message">
       <p>{message}</p>

diff --git a/src/components/LoadingSpinner.tsx b/src/components/LoadingSpinner.tsx
@@ -1,4 +1,4 @@
-export function LoadingSpinner(): JSX.Element {
+export function LoadingSpinner(): React.JSX.Element {
   return (
     <div className="loading-spinner">
       <div className="spinner" />

diff --git a/src/main.tsx b/src/main.tsx
@@ -3,7 +3,12 @@ import { createRoot } from 'react-dom/client'
 import './index.css'
 import App from './App.tsx'
 
-createRoot(document.getElementById('root')!).render(
+const rootElement = document.getElementById('root');
+if (rootElement === null) {
+  throw new Error('Root element not found');
+}
+
+createRoot(rootElement).render(
   <StrictMode>
     <App />
   </StrictMode>,

diff --git a/src/services/github.ts b/src/services/github.ts
@@ -81,7 +81,7 @@ async function processIssueComments(issue: GitHubIssue): Promise<BotActivity[]>
       const successComment = nextComments.find(isSuccessComment);
       const failureComment = nextComments.find(isFailureComment);
 
-      if ((successComment !== undefined || failureComment !== undefined) && issue.number !== undefined) {
+      if (successComment !== undefined || failureComment !== undefined) {
         const resultComment = successComment ?? failureComment;
         if (resultComment !== undefined) {
           activities.push({
@@ -113,7 +113,7 @@ async function processPRComments(pr: GitHubPR): Promise<BotActivity[]> {
       const successComment = nextComments.find(isPRModificationSuccessComment);
       const failureComment = nextComments.find(isPRModificationFailureComment);
 
-      if ((successComment !== undefined || failureComment !== undefined) && pr.number !== undefined) {
+      if (successComment !== undefined || failureComment !== undefined) {
         const resultComment = successComment ?? failureComment;
         if (resultComment !== undefined) {
           activities.push({