Reduce memory usage in editor operations #58
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implement line-by-line file reading instead of reading entire files into memory - Use file copying for history instead of keeping content in memory - Optimize string search and replacement to work line by line - Improve file operations to use buffered I/O - Add memory usage tests to verify improvements - Make memory tests more realistic about Python's memory behavior Fixes #56
neubig
force-pushed
the
reduce-memory-usage
branch
from
a3ec7f4 to
18ecc25
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #56 by reducing memory usage in editor operations.
Changes
Add chunked reading support to reduce memory usage
read_file_chunksmethod that yields chunks of a file contentread_fileto use chunked readingcount_occurrencesmethod that uses chunked readingModify file operations to use less memory
str_replace: Now processes the file in chunksinsert: Also processes the file in chunksview: Uses chunked reading and line-by-line readingImprove temporary file handling
Test Results
Added memory usage tests that verify:
All tests are passing.