Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: vscode support for modal runtime #6442

Merged
merged 2 commits into from
Jan 24, 2025
Merged

feat: vscode support for modal runtime #6442

merged 2 commits into from
Jan 24, 2025
+31 −1

Conversation

zxh3
Copy link
Contributor

@zxh3 zxh3 commented Jan 24, 2025 •
edited
Loading

End-user friendly description of the problem this fixes or functionality that this introduces

  • Include this change in the Release Notes. If checked, you must provide an end-user friendly description for your change below

Give a summary of what the PR does, explaining any non-trivial design decisions

e2e.mov

Link of any specific issues this addresses

enyst
enyst approved these changes Jan 24, 2025
View reviewed changes
Copy link
Collaborator

@enyst enyst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

We may want to look into implementing a search for an open port, like DockerRuntime is doing, instead of hardcoding strictly one, but it doesn't have to be this PR.

@enyst enyst enabled auto-merge (squash) January 24, 2025 01:35
@enyst enyst merged commit ad2237d into All-Hands-AI:main Jan 24, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enyst enyst enyst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zxh3 @enyst