Fix server linting issues #6399
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix bytes vs str return type in auth.py - Handle None client in middleware.py - Fix return type mismatches in settings.py
neubig
commented
Jan 21, 2025
Comment on lines
+78
to
+79
| if not request.client: | ||
| return True # Allow requests without client info |
There was a problem hiding this comment.
I'm not very sure if this is ideal behavior here, would it be better to raise an exception?
There was a problem hiding this comment.
It should be okay, but it might not matter because we're thinking to remove the rate limiting here
li-boxuan
reviewed
Jan 23, 2025
| logger.warning(str(e)) | ||
| raise HTTPException( | ||
| status_code=status.HTTP_404_NOT_FOUND, | ||
| detail='Settings not found', |
There was a problem hiding this comment.
This assumes any ValueError must be the error you threw at L29, which might be true now, but can evolve quickly.
How about throwing an HTTPException at L29, and here you could do
except HTTPException:
raise
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes several linting issues in the server code:
All linting checks now pass for the server directory.
Part of #6397
To run this PR locally, use the following command: