Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename trajectories_path config to save_trajectory_path #6216

Merged
merged 3 commits into from
Jan 14, 2025

Conversation

li-boxuan
Copy link
Collaborator

@li-boxuan li-boxuan commented Jan 13, 2025

End-user friendly description of the problem this fixes or functionality that this introduces

Breaking change: Rename trajectories_path config to save_trajectory_path

  • Include this change in the Release Notes. If checked, you must provide an end-user friendly description for your change below

Give a summary of what the PR does, explaining any non-trivial design decisions

This is a breaking change to facilitate #6215 , which adds a new option, replay_trajectory_path. To make it clear that this existing option is used to dump/save the current trajectory, I think a renaming would be preferable.

This option is currently used by https://github.com/TheAgentCompany/TheAgentCompany/blob/2dd92500dac359a7959a4e13068452af3e2c2cce/evaluation/run_eval.py#L38 but I don't think it's widely used, since:

  1. It's only documented in config doc
  2. It's only used by headless mode

Link of any specific issues this addresses


To run this PR locally, use the following command:

docker run -it --rm   -p 3000:3000   -v /var/run/docker.sock:/var/run/docker.sock   --add-host host.docker.internal:host-gateway   -e SANDBOX_RUNTIME_CONTAINER_IMAGE=docker.all-hands.dev/all-hands-ai/runtime:e786c90-nikolaik   --name openhands-app-e786c90   docker.all-hands.dev/all-hands-ai/openhands:e786c90

Copy link
Collaborator

@xingyaoww xingyaoww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@li-boxuan li-boxuan enabled auto-merge (squash) January 14, 2025 04:04
@li-boxuan li-boxuan merged commit 92b8d55 into main Jan 14, 2025
15 checks passed
@li-boxuan li-boxuan deleted the boxuanli/rename-save-trajectory-config branch January 14, 2025 04:32
csmith49 pushed a commit to csmith49/OpenHands that referenced this pull request Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants