-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Issue #3325 #5004
Fix Issue #3325 #5004
Conversation
Added a configuration options md file to openhands/docs. Added appropriately to sidebars.ts. Fixes All-Hands-AI#3325
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for working on this, @Mr-Imperium ! This issue might be tricky, because of just how many configuration options there are.
- I would mostly suggest to take a look at
config.toml.template
file, here, we have usually tried to keep it up to date, as an example that users can modify as they need - I'm afraid the LLM you used hallucinated some default values 😅. For example, AWS defaults are all None, there's no 'us-west' anywhere. The LLM specific options, including AWS options, are here, the same for others, like prompt caching is by default
True
. - for the record, the config module where all *config.py files are, is the implementation of all these options
@Mr-Imperium Sorry, I think there are two files now? Can you please take a look |
Updated, please review them. |
@Mr-Imperium This looks good! Only had very minor tweaks to suggest, please take a quick look if you can. Happy to approve this PR if that's fine with you. This is a good start to document all these, thank you for doing this! |
Co-authored-by: Engel Nyst <[email protected]>
Co-authored-by: Engel Nyst <[email protected]>
Co-authored-by: Engel Nyst <[email protected]>
Co-authored-by: Engel Nyst <[email protected]>
Co-authored-by: Engel Nyst <[email protected]>
Co-authored-by: Engel Nyst <[email protected]>
Co-authored-by: Engel Nyst <[email protected]>
Co-authored-by: Engel Nyst <[email protected]>
Co-authored-by: Engel Nyst <[email protected]>
Happy to have been able to contribute! Just a beginner; your guidance has been invaluable. Thanks! |
@mamoodi I think the contents here are great to have and this kind of doc is needed for a long time, so I'd like to take this in. |
Added a configuration options md file to openhands/docs. Added appropriately to sidebars.ts. Fixes #3325
End-user friendly description of the problem this fixes or functionality that this introduces
Added documentation for the configuration options on the docsite.
Resolves #3325