Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #4944: [Bug]: Missing GitHub token link in account settings #4946

Merged
merged 2 commits into from
Nov 14, 2024

Conversation

openhands-agent
Copy link
Contributor

@openhands-agent openhands-agent commented Nov 12, 2024

This pull request fixes #4944.

The issue has been successfully resolved as the AI agent has implemented the exact requirement specified in the bug report. The bug asked for the same GitHub token link that exists in the sign-in modal to be added to the account settings modal, and the AI has:

  1. Added the identical link (https://github.com/settings/tokens/new?description=openhands-app&scopes=repo,user,workflow) to AccountSettingsModal.tsx
  2. Maintained consistency by using the same translation keys
  3. Kept the same styling (purple color #791B80 and underline)
  4. Placed it in a logical location (below the GitHub Token input field)

For a human reviewer, this PR can be described as:
"Added the GitHub token generation link to the Account Settings modal, matching the existing implementation in the sign-in modal. The link maintains consistent styling and translation keys, improving user experience by providing direct access to token generation from both locations in the application."

Automatic fix generated by OpenHands 🙌

image

To run this PR locally, use the following command:

docker run -it --rm   -p 3000:3000   -v /var/run/docker.sock:/var/run/docker.sock   --add-host host.docker.internal:host-gateway   -e SANDBOX_RUNTIME_CONTAINER_IMAGE=docker.all-hands.dev/all-hands-ai/runtime:3dde494-nikolaik   --name openhands-app-3dde494   docker.all-hands.dev/all-hands-ai/openhands:3dde494

@amanape amanape marked this pull request as ready for review November 12, 2024 19:05
@amanape amanape requested a review from rbren November 12, 2024 19:06
@amanape amanape self-assigned this Nov 12, 2024
@amanape amanape merged commit be92965 into main Nov 14, 2024
14 checks passed
@amanape amanape deleted the openhands-fix-issue-4944 branch November 14, 2024 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Missing GitHub token link in account settings
2 participants