-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Replace pexpect with libtmux in BashSession #4881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add test for session initialization with custom working directory and username - Add test for pwd property updates - Add test for special characters in command output - Add test for multiple commands in sequence - Add test for long-running commands with output - Add test for multiline command input - Add test for ANSI escape codes - Add test for long output
Wow, this is really happening! Thank you so much! |
rbren
reviewed
Jan 3, 2025
openhands/runtime/impl/action_execution/action_execution_client.py
Outdated
Show resolved
Hide resolved
rbren
approved these changes
Jan 3, 2025
Congrats on landing this one! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the pexpect-based shell interaction with a more robust libtmux implementation, providing better reliability and functionality for command execution in OpenHands.
Key Improvements
Technical Details
keep_prompt
parameter from CmdRunAction as it's no longer needed with tmuxEnd-user Benefits
Development Notes
Collaborated with OpenHands:
To run this PR locally, use the following command: