Issue #4399 : Replaced all occurences #4878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enyst
reviewed
Nov 11, 2024
|
Thank you for this, it will be cleaner for sure! Just a small thought I have on compatibility. |
Updated Event.py and Message.py for deserialization.
…into issue4399
Mr-Imperium
commented
Nov 11, 2024
There was a problem hiding this comment.
@enyst I did the following changes.
Added a check for the images_urls in event.py.
To further ensure compatibility, added a property in the message,py that points images_urls to image_urls.
enyst
reviewed
Nov 11, 2024
Updated for compatibility as instructed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #4399
End-user friendly description of the problem this fixes or functionality that this introduces
Give a summary of what the PR does, explaining any non-trivial design decisions
Replaced all occurrences of 'images_urls' to 'image_urls'
Link of any specific issues this addresses