Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix infinite loop #4873

Merged
merged 4 commits into from
Nov 11, 2024
Merged

fix infinite loop #4873

merged 4 commits into from
Nov 11, 2024

Conversation

rbren
Copy link
Collaborator

@rbren rbren commented Nov 9, 2024

End-user friendly description of the problem this fixes or functionality that this introduces

  • Include this change in the Release Notes. If checked, you must provide an end-user friendly description for your change below

Give a summary of what the PR does, explaining any non-trivial design decisions

the /authenticate endpoint can trigger an infinite loop 😬


Link of any specific issues this addresses


To run this PR locally, use the following command:

docker run -it --rm   -p 3000:3000   -v /var/run/docker.sock:/var/run/docker.sock   --add-host host.docker.internal:host-gateway   -e SANDBOX_RUNTIME_CONTAINER_IMAGE=docker.all-hands.dev/all-hands-ai/runtime:b6dd1da-nikolaik   --name openhands-app-b6dd1da   docker.all-hands.dev/all-hands-ai/openhands:b6dd1da

@rbren rbren marked this pull request as ready for review November 9, 2024 23:01
Copy link
Collaborator

@tofarr tofarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦 - Good catch

Copy link
Member

@amanape amanape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amanape amanape enabled auto-merge (squash) November 11, 2024 10:42
@amanape amanape merged commit bf8ccc8 into main Nov 11, 2024
13 checks passed
@amanape amanape deleted the rb/fix-loop branch November 11, 2024 10:59
rbren added a commit that referenced this pull request Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants