Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't persist cache on reload #4854

Merged
merged 8 commits into from
Nov 8, 2024
Merged

Don't persist cache on reload #4854

merged 8 commits into from
Nov 8, 2024

Conversation

rbren
Copy link
Collaborator

@rbren rbren commented Nov 8, 2024

End-user friendly description of the problem this fixes or functionality that this introduces

  • Include this change in the Release Notes. If checked, you must provide an end-user friendly description for your change below
    no changelog

Give a summary of what the PR does, explaining any non-trivial design decisions

This was killing me in dev mode 🙃

Full refresh should clear this cache, even in prod. Removing local storage


Link of any specific issues this addresses


To run this PR locally, use the following command:

docker run -it --rm   -p 3000:3000   -v /var/run/docker.sock:/var/run/docker.sock   --add-host host.docker.internal:host-gateway   -e SANDBOX_RUNTIME_CONTAINER_IMAGE=docker.all-hands.dev/all-hands-ai/runtime:74054dd-nikolaik   --name openhands-app-74054dd   docker.all-hands.dev/all-hands-ai/openhands:74054dd

@rbren rbren marked this pull request as ready for review November 8, 2024 21:09
Copy link
Collaborator

@tofarr tofarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍰

@rbren rbren enabled auto-merge (squash) November 8, 2024 22:16
@rbren rbren merged commit 35c6886 into main Nov 8, 2024
13 checks passed
@rbren rbren deleted the rb/no-persist-cache branch November 8, 2024 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants