-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace file editor with openhands-aci #4782
Merged
xingyaoww
merged 9 commits into
All-Hands-AI:main
from
ryanhoangt:replace-file-editor-with-oh-aci
Nov 12, 2024
Merged
Replace file editor with openhands-aci #4782
xingyaoww
merged 9 commits into
All-Hands-AI:main
from
ryanhoangt:replace-file-editor-with-oh-aci
Nov 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@xingyaoww I have tried to test via the UI and it looks good to me. Your existing unit tests also passed, with minor changes in error messages. I think it's ready for eval now |
1 task
xingyaoww
reviewed
Nov 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few nit - otherwise LGTM! This is a awesome start to cleanup our codebase :)
xingyaoww
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
End-user friendly description of the problem this fixes or functionality that this introduces
Give a summary of what the PR does, explaining any non-trivial design decisions
This PR is to:
openhands-aci
with the existing file editoropenhands-aci
into OpenHandsLink of any specific issues this addresses