Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace file editor with openhands-aci #4782

Merged

Conversation

ryanhoangt
Copy link
Contributor

@ryanhoangt ryanhoangt commented Nov 6, 2024

End-user friendly description of the problem this fixes or functionality that this introduces

  • Include this change in the Release Notes. If checked, you must provide an end-user friendly description for your change below

Give a summary of what the PR does, explaining any non-trivial design decisions

This PR is to:

  • Verify feature parity of openhands-aci with the existing file editor
  • Integrate openhands-aci into OpenHands

Link of any specific issues this addresses

@ryanhoangt ryanhoangt marked this pull request as draft November 6, 2024 09:32
@ryanhoangt
Copy link
Contributor Author

@xingyaoww I have tried to test via the UI and it looks good to me. Your existing unit tests also passed, with minor changes in error messages. I think it's ready for eval now

@ryanhoangt
Copy link
Contributor Author

(1) We got the same success rate with CodeAct v2.2:

Screenshot 2024-11-10 at 12 38 40

@xingyaoww xingyaoww marked this pull request as ready for review November 10, 2024 14:22
Copy link
Collaborator

@xingyaoww xingyaoww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few nit - otherwise LGTM! This is a awesome start to cleanup our codebase :)

pyproject.toml Outdated Show resolved Hide resolved
tests/unit/test_agent_skill.py Show resolved Hide resolved
@ryanhoangt ryanhoangt requested a review from xingyaoww November 11, 2024 10:11
@xingyaoww xingyaoww enabled auto-merge (squash) November 12, 2024 13:25
@xingyaoww xingyaoww merged commit d9c5f11 into All-Hands-AI:main Nov 12, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants