Use i18n Keys (2) #4464
Use i18n Keys (2) #4464
Conversation
There was a problem hiding this comment.
You're on the right path! It would be helpful if you could also update your description to include the files and directories you plan on covering, e.g.,
- modals
- forms
And so on...
This will help sync with @Vaishakh-SM and reduce chances of conflicts
|
Hi @amanape sorry for the time away, I was a bit bussy. I updated the description with the files I'm taking and its current status. I wanted to ask you something before advancing more, I realized there are some resources that have a standard where the name is the resource plus the context in which they are used. i.e:
I saw some other resources that don't hold this standard and just have a brief piece of the text. i.e:
I know this does not affect functionality but I am an advocate of standards 😅 so I like to keep things consistent So I wanted to know if you think this is a standard worth keeping or I better use just the name being a part of the text. I think those sufixes can make the name longer, and in context, the resource should not care where its used, but what it says (as long as the context does not change the meaning). Keeping those sufixes can reduce reusability: for example if a label and a message both say "success", with the suffixes you might need to create two resources "SUCCESS_LABEL" and "SUCCESS_MESSAGE" even though both could just be one single resource "SUCCESS". But if you know a reason to keep them let me know to see if its needed to update the translations I've done so far. Thank you. @Vaishakh-SM I'd like to hear also your opinion 🙈 . |
|
Yes sure, enforcing standards is always a good practice! |
Adds translations for toasts
…tins from the modals folder
|
Hi @amanape Github also is telling me that there are conflics with 3 files, let me know if you can resolve them or I have to update locally to resolve them. I stay tuned for any feedback, thank you 😄 |
|
Hey @danicruz0415, I am unable to resolve the conflicts because the changes are in your forked repository instead of a branch of this one. You're going to have to resolve them yourself but note that |
|
Hi @amanape I think I just resolved the conflicts, first time with that scary message "These conflicts are too complex to resolve in the web editor" 😅. |
End-user friendly description of the problem this fixes or functionality that this introduces
Work in progress. Updates interface components to use i18next keys so that the user can view them in different languages. See also this PR
Link of any specific issues this addresses
#4280
This PR is meant to cover all the folders that are missing translations. The files outside the folders are being handled here
🟦 means does not need localization
🟩 means its already localized
🟥 means needs localization