Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2 things done:
There seemed to be extra logic with 64 (center) and 127 (right) values, I commented them out instead of removing them, unsure how you want to handle it, for original reversing efforts.
As a side note there was actually a comment in
PsxSpuApi.cpp
about assigningfield_3_pan
tofield_11_pad
. I'm tempted to changefield_11_pad
topan
.Further, the change is duplicated for AO and AE, combining them would be too large of a change for this PR I think. Also, some of the values passed in places for left or right pan are unused now, so cleanup could be done.