Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audio panning #1466

Closed
wants to merge 7 commits into from
Closed

Conversation

sean-horton
Copy link
Contributor

2 things done:

  • These changes allow audio panning of audio sequences, most notable on the title tracks of both AO and AE.
  • I commented "wait until" logic around the sequence loop. It seems to have waited every 30ms before checking sequences. While it's only 30ms, audio sounded like it was racing or slowing down at times, i.e. off beat. I wonder if this check was originally to save CPU cycles, but I doubt it's an issue on new hardware.

There seemed to be extra logic with 64 (center) and 127 (right) values, I commented them out instead of removing them, unsure how you want to handle it, for original reversing efforts.

As a side note there was actually a comment in PsxSpuApi.cpp about assigning field_3_pan to field_11_pad. I'm tempted to change field_11_pad to pan.

Further, the change is duplicated for AO and AE, combining them would be too large of a change for this PR I think. Also, some of the values passed in places for left or right pan are unused now, so cleanup could be done.

@sean-horton
Copy link
Contributor Author

Closing this pull request as it is the wrong approach. I opened a second pull request that may be better.
#1469

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant