-
-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for HD cams. #1344
Open
mlgthatsme
wants to merge
39
commits into
AliveTeam:master
Choose a base branch
from
mlgthatsme:opengl
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+4,709
−532
Open
Add support for HD cams. #1344
Changes from 4 commits
Commits
Show all changes
39 commits
Select commit
Hold shift + click to select a range
8485d30
Added type variable to Renderer + Added hd cam support for opengl.
mlgthatsme e4b25af
Merge remote-tracking branch 'origin/master'
mlgthatsme 1d98b56
fix compile poop
mlgthatsme 763bf8c
Change LoadCustomCAM to LoadExternalCam - Add warning logs
mlgthatsme 3e68c03
imgui demo code included in cmake
mlgthatsme 83a4a57
finally fixed issue where certain sprites rendered incorrectly.
mlgthatsme 6c8e7d4
removed redundant rendererType variable
mlgthatsme a046cb0
fixed issue where background wasn't loading properly.
mlgthatsme 10e40d7
add checks for opengl calls + gpu info window
mlgthatsme 3a1c94a
Call end frame.
mlgthatsme 24eb07f
Merge remote-tracking branch 'origin/master' into opengl
mlgthatsme 7ed4239
Merge remote-tracking branch 'origin/master' into opengl
mlgthatsme 5444a82
Merge remote-tracking branch 'origin/master' into opengl
mlgthatsme 30f4f4c
add imgui stdlib for std::string helper functions
mlgthatsme 80ee9f3
asset tool + extra masher funcs
mlgthatsme b5778ad
add variable to know if game is ae or ae
mlgthatsme 1c10b53
add present to renderer functions + hd asset loading wip
mlgthatsme ab43d65
Merge branch 'AliveTeam:master' into opengl
mlgthatsme 042a375
fix some warnings
mlgthatsme 143cf86
check if folder name is valid for loading external assets. skip on fail
mlgthatsme 71146ae
Change how we apply hd textures, use global table instead
mlgthatsme 62fa3a0
Make slig render in shadows properly
mlgthatsme 6609f97
make it so emissive textures only render if object is dark
mlgthatsme e3062e3
fix signed char causing overflow issues with rgb color
mlgthatsme 37d1a6f
fix incorrect resource files for abe falling and die
mlgthatsme f9ea48c
new and improved
mlgthatsme 9416fb0
add support for flipped textures and flipped emissive textures
mlgthatsme 64bf2e9
fix a bunch of anims not exporting due to wrong anim info
mouzedrift cfc605f
AO hd cam support + meta json error handling
mouzedrift 6523a83
fix wrong paramite animation names
mouzedrift 8c0ab04
enable RENDERER_OPENGL by default
mouzedrift 89ab3b9
fix warnings
mouzedrift fc127a4
normalize flying slig anim id names
mouzedrift 8e63510
make loading hd sprites a bit faster
mouzedrift 72eb641
don't try to play movies
mouzedrift b1eddbf
don't load broken fg1 in AO
mouzedrift b34d8b0
show progress while loading external animations
mouzedrift 7fea3cb
add ability to toggle the debug window and external assets using F1 a…
mouzedrift e6593da
add original data to meta.json files
mouzedrift File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -20,6 +20,8 @@ void DirectX9Renderer::Destroy() | |
|
||
bool DirectX9Renderer::Create(TWindowHandleType window) | ||
{ | ||
rendererType = Renderers::DirectX9; | ||
|
||
// Find the directx9 driver | ||
const s32 numDrivers = SDL_GetNumRenderDrivers(); | ||
if (numDrivers < 0) | ||
|
@@ -180,4 +182,9 @@ void DirectX9Renderer::Upload(BitDepth /*bitDepth*/, const PSX_RECT& /*rect*/, c | |
{ | ||
} | ||
|
||
void DirectX9Renderer::LoadExternalCam(const char* /*path*/, const unsigned char* /*key*/, int /*keyLength*/) | ||
{ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. should prob log it isn't implemented with LOG_WARNING |
||
LOG_WARNING("LoadExternalCam not implemented for DirectX9 - external cam not loaded."); | ||
} | ||
|
||
#endif |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,6 +11,7 @@ void SoftwareRenderer::Destroy() | |
|
||
bool SoftwareRenderer::Create(TWindowHandleType window) | ||
{ | ||
rendererType = Renderers::Software; | ||
mRenderer = SDL_CreateRenderer(window, -1, 0); | ||
return mRenderer != nullptr; | ||
} | ||
|
@@ -231,3 +232,8 @@ void SoftwareRenderer::Upload(BitDepth bitDepth, const PSX_RECT& rect, const u8* | |
break; | ||
} | ||
} | ||
|
||
void SoftwareRenderer::LoadExternalCam(const char* /*path*/, const unsigned char* /*key*/, int /*keyLength*/) | ||
{ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. should prob log it isn't implemented with LOG_WARNING |
||
LOG_WARNING("LoadExternalCam not implemented for Software Renderer - external cam not loaded."); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't used anywhere
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how are we supposed to tell what renderer the user would be using? how would you approach that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use polymorphic calls to abstract it out - e.g Create is a virtual call so DirectX9Renderer::Create know its the directx impl. If something outside of the object using the base type needs to know this then its probably leaking implementation details.
But its not even used currently so its dead code anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
alright. done.