Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix goroutine logic bug #7215

Closed
wants to merge 2 commits into from
Closed

Fix goroutine logic bug #7215

wants to merge 2 commits into from

Conversation

hshpy
Copy link
Contributor

@hshpy hshpy commented Sep 18, 2024

提前返回导致后面Channel下载任务不执行

Copy link

welcome bot commented Sep 18, 2024

Thanks for opening this pull request! Please check out our contributing guidelines.

@j2rong4cn
Copy link
Contributor

改成这样之后好像是1条连接2个通道同时下载,,像阿里云盘Open是1条连接限速500k左右,并不能加速下载

@hshpy
Copy link
Contributor Author

hshpy commented Jan 13, 2025

改成这样之后好像是1条连接2个通道同时下载,,像阿里云盘Open是1条连接限速500k左右,并不能加速下载

这里我只修正了逻辑给夸克驱动用,其它驱动可以加参数开启,看我仓库的提交。

@j2rong4cn
Copy link
Contributor

j2rong4cn commented Jan 13, 2025

改成这样之后好像是1条连接2个通道同时下载,,像阿里云盘Open是1条连接限速500k左右,并不能加速下载

这里我只修正了逻辑给夸克驱动用,其它驱动可以加参数开启,看我仓库的提交。

把Concurrency设置大于1确实有问题,我把Concurrency设置成16,只有一开始是16个通道在下载,之后就只有一个

@xhofe @SeanHeuc 请求合并

j2rong4cn added a commit to j2rong4cn/alist that referenced this pull request Jan 17, 2025
* Fix goroutine logic bug

* Fix bug

---------

Co-authored-by: hpy hs <[email protected]>
@j2rong4cn
Copy link
Contributor

你这个PR可以取消吗?我提交了个pro max版本的

@hshpy hshpy closed this Jan 17, 2025
j2rong4cn added a commit to j2rong4cn/alist that referenced this pull request Jan 20, 2025
commit 524267b
Author: j2rong4cn <[email protected]>
Date:   Mon Jan 20 18:54:58 2025 +0800

    refactor

commit f4ba815
Author: j2rong4cn <[email protected]>
Date:   Sun Jan 19 18:16:45 2025 +0800

    refactor

commit 8e78e4f
Author: j2rong4cn <[email protected]>
Date:   Sat Jan 18 19:17:58 2025 +0800

    pref(net): create `chunk` on demand

commit d04d606
Author: j2rong4cn <[email protected]>
Date:   Sat Jan 18 13:14:40 2025 +0800

    feat(net): add `ConcurrencyLimit`

commit edbc8c9
Author: j2rong4cn <[email protected]>
Date:   Tue Jan 14 23:58:11 2025 +0800

    feat(alias):  add `DownloadConcurrency` and `DownloadPartSize` option

commit fa65e5f
Author: j2rong4cn <[email protected]>
Date:   Fri Jan 17 18:26:43 2025 +0800

    fix(net): incorrect error return

commit ac03454
Author: j2rong4cn <[email protected]>
Date:   Fri Jan 17 18:24:36 2025 +0800

    perf(net): sequential and dynamic concurrency

commit 866fe8d
Author: j2rong4cn <[email protected]>
Date:   Tue Dec 31 00:31:30 2024 +0800

    fix(net): goroutine logic bug (AlistGo#7215)

    * Fix goroutine logic bug

    * Fix bug

    ---------

    Co-authored-by: hpy hs <[email protected]>
j2rong4cn added a commit to j2rong4cn/alist that referenced this pull request Jan 21, 2025
commit f2ce10c
Author: j2rong4cn <[email protected]>
Date:   Wed Jan 22 04:08:58 2025 +0800

    refactor

commit f7bcacb
Author: j2rong4cn <[email protected]>
Date:   Tue Jan 21 19:08:37 2025 +0800

    fix(net): `r.Closers.Add` has no effect

commit 524267b
Author: j2rong4cn <[email protected]>
Date:   Mon Jan 20 18:54:58 2025 +0800

    refactor

commit f4ba815
Author: j2rong4cn <[email protected]>
Date:   Sun Jan 19 18:16:45 2025 +0800

    refactor

commit 8e78e4f
Author: j2rong4cn <[email protected]>
Date:   Sat Jan 18 19:17:58 2025 +0800

    pref(net): create `chunk` on demand

commit d04d606
Author: j2rong4cn <[email protected]>
Date:   Sat Jan 18 13:14:40 2025 +0800

    feat(net): add `ConcurrencyLimit`

commit edbc8c9
Author: j2rong4cn <[email protected]>
Date:   Tue Jan 14 23:58:11 2025 +0800

    feat(alias):  add `DownloadConcurrency` and `DownloadPartSize` option

commit fa65e5f
Author: j2rong4cn <[email protected]>
Date:   Fri Jan 17 18:26:43 2025 +0800

    fix(net): incorrect error return

commit ac03454
Author: j2rong4cn <[email protected]>
Date:   Fri Jan 17 18:24:36 2025 +0800

    perf(net): sequential and dynamic concurrency

commit 866fe8d
Author: j2rong4cn <[email protected]>
Date:   Tue Dec 31 00:31:30 2024 +0800

    fix(net): goroutine logic bug (AlistGo#7215)

    * Fix goroutine logic bug

    * Fix bug

    ---------

    Co-authored-by: hpy hs <[email protected]>
j2rong4cn added a commit to j2rong4cn/alist that referenced this pull request Jan 23, 2025
* Fix goroutine logic bug

* Fix bug

---------

Co-authored-by: hpy hs <[email protected]>
j2rong4cn added a commit to j2rong4cn/alist that referenced this pull request Jan 23, 2025
commit 97ee3f9
Author: j2rong4cn <[email protected]>
Date:   Thu Jan 23 14:08:12 2025 +0800

    refactor

commit 822b1df
Author: j2rong4cn <[email protected]>
Date:   Tue Jan 21 19:08:37 2025 +0800

    fix(net): `r.Closers.Add` has no effect

commit 1e72e70
Author: j2rong4cn <[email protected]>
Date:   Mon Jan 20 18:54:58 2025 +0800

    refactor

commit cc55294
Author: j2rong4cn <[email protected]>
Date:   Sun Jan 19 18:16:45 2025 +0800

    refactor

commit 4dd8746
Author: j2rong4cn <[email protected]>
Date:   Sat Jan 18 19:17:58 2025 +0800

    pref(net): create `chunk` on demand

commit 60407c3
Author: j2rong4cn <[email protected]>
Date:   Sat Jan 18 13:14:40 2025 +0800

    feat(net): add `ConcurrencyLimit`

commit d5e51ce
Author: j2rong4cn <[email protected]>
Date:   Tue Jan 14 23:58:11 2025 +0800

    feat(alias):  add `DownloadConcurrency` and `DownloadPartSize` option

commit 46bd0a7
Author: j2rong4cn <[email protected]>
Date:   Fri Jan 17 18:26:43 2025 +0800

    fix(net): incorrect error return

commit 45ec9d3
Author: j2rong4cn <[email protected]>
Date:   Fri Jan 17 18:24:36 2025 +0800

    perf(net): sequential and dynamic concurrency

commit 6622552
Author: j2rong4cn <[email protected]>
Date:   Tue Dec 31 00:31:30 2024 +0800

    fix(net): goroutine logic bug (AlistGo#7215)

    * Fix goroutine logic bug

    * Fix bug

    ---------

    Co-authored-by: hpy hs <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants