Fix most of the warnings (#165)

* Fix a bunch of warnings

Framework/include/QualityControl/ServiceDiscovery.h

@@ -10,6 +10,7 @@
 #include <memory>
 #include <string>
 #include <thread>
+#include <boost/asio/ip/host_name.hpp>
 
 namespace o2::quality_control::core
 {
@@ -58,7 +59,10 @@ class ServiceDiscovery
   /// Health check thread loop
   void runHealthServer(unsigned int port);
 
-  static inline std::string GetDefaultUrl(); ///< Provides default health check URL
+  static inline std::string GetDefaultUrl() ///< Provides default health check URL
+  {
+    return boost::asio::ip::host_name() + ":" + std::to_string(7777);
+  }
 };
 
 } // namespace o2::quality_control::core

Framework/src/Checker.cxx

@@ -94,7 +94,8 @@ void Checker::init(framework::InitContext&)
     mCollector = MonitoringFactory::Get("infologger://");
   } catch (...) {
     std::string diagnostic = boost::current_exception_diagnostic_information();
-    LOG(ERROR) << "Unexpected exception, diagnostic information follows:\n" << diagnostic;
+    LOG(ERROR) << "Unexpected exception, diagnostic information follows:\n"
+               << diagnostic;
     throw;
   }
   startFirstObject = system_clock::time_point::min();
@@ -110,13 +111,13 @@ void Checker::run(framework::ProcessingContext& ctx)
     startFirstObject = system_clock::now();
   }
 
-  std::shared_ptr<TObjArray> moArray{ std::move(framework::DataRefUtils::as<TObjArray>(*ctx.inputs().begin())) };
+  std::shared_ptr<TObjArray> moArray{ framework::DataRefUtils::as<TObjArray>(*ctx.inputs().begin()) };
   moArray->SetOwner(false);
   auto checkedMoArray = std::make_unique<TObjArray>();
   checkedMoArray->SetOwner();
 
   for (const auto& to : *moArray) {
-    std::shared_ptr<MonitorObject> mo{dynamic_cast<MonitorObject*>(to)};
+    std::shared_ptr<MonitorObject> mo{ dynamic_cast<MonitorObject*>(to) };
     moArray->RemoveFirst();
     if (mo) {
       check(mo);

Framework/src/CheckerFactory.cxx

@@ -36,7 +36,7 @@ DataProcessorSpec CheckerFactory::create(std::string checkerName, std::string ta
                                 std::vector<std::string>{},
                                 std::vector<DataProcessorLabel>{} };
 
-  return std::move(newChecker);
+  return newChecker;
 }
 
 } // namespace o2::quality_control::checker

Framework/src/DataDumpGui.cxx

@@ -139,7 +139,6 @@ void updatePayloadGui()
     // header row
     ImGui::Separator();
     resizeColumns(representation /*, old_representation*/);
-    ImGui::Text("");
     ImGui::NextColumn();
     ImGui::Text("#1");
     ImGui::NextColumn();
@@ -211,7 +210,7 @@ void updateHeaderGui()
                       ImVec2(ImGui::GetWindowContentRegionWidth() * 0.5f, ImGui::GetTextLineHeightWithSpacing() * 7),
                       false);
     ImGui::Text("Header size : %d", header->headerSize);
-    ImGui::Text("Payload size : %llu", header->payloadSize);
+    ImGui::Text("Payload size : %llu", static_cast<unsigned long long int>(header->payloadSize));
     ImGui::Text("Header version : %d", header->headerVersion);
     ImGui::Text("flagsNextHeader : %d", header->flagsNextHeader);
     ImGui::Text("dataDescription : %s", header->dataDescription.str);

Framework/src/ExamplePrinterSpec.h

@@ -31,7 +31,7 @@ class ExamplePrinterSpec : public framework::Task
   void run(ProcessingContext& processingContext) final
   {
     LOG(INFO) << "Received data";
-    std::shared_ptr<TObjArray> moArray{ std::move(DataRefUtils::as<TObjArray>(*processingContext.inputs().begin())) };
+    std::shared_ptr<TObjArray> moArray{ DataRefUtils::as<TObjArray>(*processingContext.inputs().begin()) };
 
     if (moArray->IsEmpty()) {
       LOG(INFO) << "Array is empty";

Framework/src/InformationService.cxx

@@ -119,6 +119,8 @@ bool InformationService::handleTaskInputData(std::string receivedData)
 
   // publish
   sendJson(json);
+
+  return true;
 }
 
 void InformationService::readFakeDataFile(std::string fakeDataFile)

Framework/src/InformationService.h

@@ -38,7 +38,7 @@ namespace pt = boost::property_tree;
 /// See runInformationService.cxx for the steering code.
 ///
 /// Example usage :
-///      qcInfoService -c /absolute/path/to/InformationService.json -n information_service \\
+///      qcInfoService -c /absolute/path/to/InformationService.json -n information_service
 ///                    --id information_service --mq-config /absolute/path/to/InformationService.json
 ///
 /// Format of the string coming from the tasks :

Framework/src/ServiceDiscovery.cxx

@@ -8,18 +8,12 @@
 #include <boost/asio.hpp>
 #include <boost/property_tree/ptree.hpp>
 #include <boost/property_tree/json_parser.hpp>
-#include <boost/asio/ip/host_name.hpp>
 #include <boost/algorithm/string/split.hpp>
 #include <boost/algorithm/string.hpp>
 
 namespace o2::quality_control::core
 {
 
-std::string ServiceDiscovery::GetDefaultUrl()
-{
-  return boost::asio::ip::host_name() + ":" + std::to_string(7777);
-}
-
 ServiceDiscovery::ServiceDiscovery(const std::string& url, const std::string& id, const std::string& healthEndpoint) : curlHandle(initCurl(), &ServiceDiscovery::deleteCurl), mConsulUrl(url), mId(id), mHealthEndpoint(healthEndpoint)
 {
   // parameter check

Framework/src/TaskRunnerFactory.cxx

@@ -34,7 +34,7 @@ TaskRunnerFactory::create(std::string taskName, std::string configurationSource,
     adaptFromTask<TaskRunner>(std::move(qcTask))
   };
 
-  return std::move(newTask);
+  return newTask;
 }
 
 } // namespace o2::quality_control::core

Framework/src/runBasic.cxx

@@ -34,6 +34,7 @@
 /// of glfw being installed or not, in the terminal all the logs will be shown as well.
 
 #include "Framework/DataSampling.h"
+
 using namespace o2::framework;
 
 void customize(std::vector<CompletionPolicy>& policies)

Framework/src/runnerUtils.h

@@ -32,8 +32,8 @@ std::string getFirstTaskName(std::string configurationSource)
 {
   auto config = o2::configuration::ConfigurationFactory::getConfiguration(configurationSource);
 
-  for (const auto&[taskName, taskConfig] : config->getRecursive("qc.tasks")) {
-    return taskName;
+  for (const auto& task : config->getRecursive("qc.tasks")) {
+    return task.first; // task name;
   }
 
   throw;

Framework/test/testDbFactory.cxx

@@ -41,7 +41,7 @@ using namespace o2::quality_control::core;
 namespace o2::quality_control::repository
 {
 
-bool do_nothing(AliceO2::Common::FatalException const& ex) { return true; }
+bool do_nothing(AliceO2::Common::FatalException const&) { return true; }
 
 BOOST_AUTO_TEST_CASE(db_factory_test)
 {

Modules/Skeleton/src/SkeletonTask.cxx

@@ -31,7 +31,7 @@ SkeletonTask::~SkeletonTask() {
   }
 }
 
-void SkeletonTask::initialize(o2::framework::InitContext& ctx)
+void SkeletonTask::initialize(o2::framework::InitContext& /*ctx*/)
 {
   QcInfoLogger::GetInstance() << "initialize SkeletonTask" << AliceO2::InfoLogger::InfoLogger::endm;