Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DPL: Reduce some verbosity from FATAL to ERROR #13877

Merged
merged 1 commit into from
Jan 20, 2025
Merged

DPL: Reduce some verbosity from FATAL to ERROR #13877

merged 1 commit into from
Jan 20, 2025

Conversation

davidrohr
Copy link
Collaborator

No need that multiple lines are FATAL, in particular the backtrace itself is also not FATAL.

@davidrohr davidrohr requested a review from a team as a code owner January 19, 2025 13:32
@github-actions GitHub Actions
Copy link
Contributor

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1

@davidrohr
Copy link
Collaborator Author

@ktf : RC asked if we can reduce the number of FATAL messages. Please have a look and merge if you see no downside.

@davidrohr davidrohr merged commit e16c810 into AliceO2Group:dev Jan 20, 2025
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ktf ktf ktf approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidrohr @ktf