Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QC-673: Merge TCanvases #13876

Merged
merged 1 commit into from
Jan 23, 2025
Merged

QC-673: Merge TCanvases #13876

merged 1 commit into from
Jan 23, 2025
+191 −4

Conversation

justonedev1
Copy link
Collaborator

So this is how I managed to merge TCanvases, before I make a PR in QC that adjusts warning for mergeable object it would be nice if you would tell me your opinion.

@github-actions GitHub Actions
Copy link
Contributor

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1

@justonedev1 justonedev1 changed the title added merging of TCanvas to mergers QC-673: Merge TCanvases Jan 17, 2025
@justonedev1 justonedev1 force-pushed the QC-673 branch 2 times, most recently from c6dc003 to 4ec3a76 Compare January 22, 2025 16:12
@justonedev1 justonedev1 marked this pull request as ready for review January 22, 2025 16:23
@justonedev1 justonedev1 requested a review from knopers8 January 22, 2025 16:23
knopers8
knopers8 previously approved these changes Jan 22, 2025
View reviewed changes
Copy link
Collaborator

@knopers8 knopers8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@alibuild
Copy link
Collaborator

Error while checking build/O2/fullCI_slc9 for 851e437 at 2025-01-22 17:34:

## sw/BUILD/ONNXRuntime-latest/log
CMake Error at /sw/slc9_x86-64/CMake/v3.28.1-13/share/cmake-3.28/Modules/CMakeFindDependencyMacro.cmake:76 (find_package):

Full log here.

@knopers8 knopers8 enabled auto-merge (squash) January 23, 2025 11:30
@knopers8 knopers8 merged commit 912f396 into dev Jan 23, 2025
13 of 15 checks passed
@knopers8 knopers8 deleted the QC-673 branch January 23, 2025 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knopers8 knopers8 knopers8 approved these changes

@Barthelemy Barthelemy Awaiting requested review from Barthelemy Barthelemy is a code owner

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@justonedev1 @alibuild @knopers8