ITS tracking: Introduce configurable minimum pt per track length #13792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
REQUEST FOR PRODUCTION RELEASES: This will add The following labels are available |
mconcas
reviewed
Dec 11, 2024
The changes introduce a configurable minimum PT value per track length in the ITS tracking parameters. This allows for more fine-grained control over the minimum PT requirement, which can be useful for different tracking scenarios. The main changes are: - Modify the `TrackingParameters` struct to include an array of 4 minimum PT values, one for each track length (7, 6, 5, 4). - Update the track fitting logic in `TrackerTraits::findRoads()` to use the appropriate minimum PT value based on the track length. - Update the default minimum PT value in `TrackingInterface::initialise()` to use the new array-based approach. These changes provide more flexibility in tuning the ITS tracking parameters.
mpuccio
force-pushed
the
mp-branch-1
branch
2 times, most recently
from
d3e4a62 to
6450331
Compare
|
Error while checking build/O2/fullCI for 6450331 at 2024-12-12 14:09: Full log here. |
|
failures are unrelated. Merging |
mconcas
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes introduce a configurable minimum PT value per track length in the ITS tracking parameters. This allows for more fine-grained control over the minimum PT requirement, which can be useful for different tracking scenarios.
The main changes are:
TrackingParametersstruct to include an array of 4 minimum PT values, one for each track length (7, 6, 5, 4).TrackerTraits::findRoads()to use the appropriate minimum PT value based on the track length.TrackingInterface::initialise()to use the new array-based approach.These changes provide more flexibility in tuning the ITS tracking parameters.