Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DCAFitterN: log-throttling for err.messages + user policy for bad CovMat #13789

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

shahor02
Copy link
Collaborator

Due to the linearization errors, the covariance matrix of the track propagated to some point may become non-positive defined. In this case, an error will be logged (logarithmically throttled), the relevant correlation coefficient of the cov.matrix is redefined to cure the position part of the cov.matrix and further program flow depends on the user settings for DCAFitterN::setBadCovPolicy(v):

DCAFitterN::setBadCovPolicy(DCAFitterN::Discard) : abandon fit (default)

DCAFitterN::setBadCovPolicy(DCAFitterN::Override): continue fit with overridden cov.matrix

DCAFitterN::setBadCovPolicy(DCAFitterN::OverrideAnFlag): continue fit with overridden cov.matrix but set the propagation failure flag (can be checked using the isPropagationFailure(int cand = 0) method).

Due to the linearization errors the covariance matrix of the track propagated to some point may become non-positive defined.
In this case an error will be logged (logarithmically throttled), the relevant correlation coefficient of the cov.matrix is
redefined to cure the position part of the cov.matrix and further program flow depends on the user settings for
DCAFitterN::setBadCovPolicy(v):

DCAFitterN::setBadCovPolicy(DCAFitterN::Discard) : abandon fit (default)

DCAFitterN::setBadCovPolicy(DCAFitterN::Override) : continue fit with overridden cov.matrix

DCAFitterN::setBadCovPolicy(DCAFitterN::OverrideAnFlag): continue fit with overridden cov.matrix but set the propagation failure flag (can be checked using the
isPropagationFailure(int cand = 0) method).
@shahor02 shahor02 requested a review from a team as a code owner December 10, 2024 15:13
Copy link
Contributor

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1

@shahor02 shahor02 merged commit c5cbdc4 into AliceO2Group:dev Dec 10, 2024
13 checks passed
@shahor02 shahor02 deleted the pr_dcafiterr branch December 10, 2024 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant