fix in track propagation to TOF for MC

[noferini]

This is to fix an issue for missing piece in track length for TOF.
For the moment it is applied only to MC since for DATA old calibrations have to be adjusted before to apply the fix

watchers: @chiarazampolli @njacazio @ercolessi

[github-actions]

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1

[noferini]

Hi @shahor02 ,
I started the review of this PR but I didn't mark it for Pb-Pb apass1. As discussed for the moment this is needed only for MC (mainly for other data passes and in view of QM approvals).
I tested it and both results and cpu performances are fine (CPU time unchanged).
... waiting for your review
Cheers,
Francesco

[shahor02]

@noferini thanks, looks good, shall I merge it already?

[noferini]

Hi @shahor02
thanks!
I think it can be merged, since RelVal is already running and I assume this will not enter in Pb-Pb apass1 reco.
Let's wait also for a confirmation by @chiarazampolli or @alcaliva

[chiarazampolli]

Thanks, merged.
We might cherry-pick this one or tag from the daily of 17.12 (where it will be included).

[chiarazampolli]

Hello,

There was a misunderstanding from this PR: I thought that the worry was that it did not go to the tag for apass1 of PbPb 2024, which is actually what @noferini wanted. So in the end it did enter... We need to revert it there.

[alcaliva]

Hi @noferini , is this feature needed also for apass7?
When porting this PR to async-v1-01-02g I get conflicts (see below)

ERROR: There was a problem cherry-picking 7e24578
Auto-merging DataFormats/Reconstruction/include/ReconstructionDataFormats/MatchInfoTOF.h
Auto-merging DataFormats/Reconstruction/include/ReconstructionDataFormats/MatchInfoTOFReco.h
Auto-merging Detectors/GlobalTracking/include/GlobalTracking/MatchTOF.h
Auto-merging Detectors/GlobalTracking/src/MatchTOF.cxx
CONFLICT (content): Merge conflict in Detectors/GlobalTracking/src/MatchTOF.cxx
error: could not apply 7e24578... fix in track propagation to TOF for MC (#13784)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

[noferini]

Hi @alcaliva ,
I resumed only today an I saw your message.
It seems to me that the conflict was due to this missing PR
#13582