Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] [EMCAL-539,EMCAL-696,EMCAL-697] FIT-CTP-EMCAL trigger simulation #12797

Closed
wants to merge 14 commits into from

Conversation

siragoni
Copy link
Contributor

@siragoni siragoni commented Mar 3, 2024

  • added the EMCAL trigger simulation in the Digitizer workflow
  • added the CTP input digits with the result of the trigger simulation

@siragoni siragoni requested review from mfasDa and jokonig as code owners March 3, 2024 20:19
Copy link
Contributor

github-actions bot commented Mar 3, 2024

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass
async-2023-pp-apass1
async-2022-pp-apass6
async-2022-pp-apass4
async-mc
async-data

Copy link
Collaborator

@mfasDa mfasDa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is almost ready. The biggest problem you still need to address is that you always run the trigger simulation. Instead it should be decided based on the trigger configuration or there should be a switch to run it on request.

Detectors/EMCAL/workflow/src/EMCALDigitizerSpec.cxx Outdated Show resolved Hide resolved
Detectors/EMCAL/workflow/src/EMCALDigitizerSpec.cxx Outdated Show resolved Hide resolved
Detectors/EMCAL/workflow/src/EMCALDigitizerSpec.cxx Outdated Show resolved Hide resolved
Detectors/EMCAL/workflow/src/EMCALDigitizerSpec.cxx Outdated Show resolved Hide resolved
@alibuild
Copy link
Collaborator

Error while checking build/O2/fullCI for 6d679fc at 2024-03-14 11:15:

## sw/BUILD/O2-latest/log
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'


## sw/BUILD/O2-full-system-test-latest/log
Detected critical problem in logfile digi.log
digi.log:[31798:EMCALDigitizer]: [10:15:00][ERROR] Exception caught: missing option: no-dig-tru (No such node (no-dig-tru)) 
[31798:EMCALDigitizer]: [10:15:00][ERROR] Exception caught: missing option: no-dig-tru (No such node (no-dig-tru)) 
[ERROR] Workflow crashed - PID 31798 (EMCALDigitizer) did not exit correctly however it's not clear why. Exit code forced to 128.


## sw/BUILD/o2checkcode-latest/log
--
========== List of errors found ==========
++ GRERR=0
++ grep -v clang-diagnostic-error error-log.txt
++ grep ' error:'
++ GRERR=1
++ [[ 1 == 0 ]]
++ mkdir -p /sw/INSTALLROOT/89241dc6cb701923cc098f35fbd59d46ac3f325e/slc8_x86-64/o2checkcode/1.0-local1507/etc/modulefiles
++ cat
--

Full log here.

@siragoni siragoni changed the title [EMCAL-539,EMCAL-696,EMCAL-697] FIT-CTP-EMCAL trigger simulation [WIP] [EMCAL-539,EMCAL-696,EMCAL-697] FIT-CTP-EMCAL trigger simulation Mar 14, 2024
Copy link
Contributor

This PR did not have any update in the last 30 days. Is it still needed? Unless further action in will be closed in 5 days.

@github-actions github-actions bot added the stale label Apr 19, 2024
@github-actions github-actions bot closed this Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants