Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QC-1008] shm-metadata-msg-size parameter mapped #12763

Merged
merged 2 commits into from
Mar 19, 2024

Conversation

justonedev1
Copy link
Collaborator

  • parameter mapped
  • added simple workflow to test the parameter values

@justonedev1 justonedev1 requested a review from a team as a code owner February 26, 2024 10:23
Copy link
Contributor

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass
async-2023-pp-apass1
async-2022-pp-apass6
async-2022-pp-apass4
async-mc
async-data

@justonedev1
Copy link
Collaborator Author

This task was issued by @knopers8

@justonedev1 justonedev1 changed the title shm-metadata-msg-size parameter mapped [QC-1008] shm-metadata-msg-size parameter mapped Feb 26, 2024
@justonedev1 justonedev1 force-pushed the QC-1008 branch 2 times, most recently from 1005eb9 to 22c8e84 Compare February 26, 2024 12:38
knopers8
knopers8 previously approved these changes Feb 26, 2024
Copy link
Collaborator

@knopers8 knopers8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
@ktf Are you OK with this?

@knopers8
Copy link
Collaborator

Thank you! @ktf Are you OK with this?

ping @ktf

@ktf
Copy link
Member

ktf commented Feb 29, 2024

I think you might need the extra parameter in a few more places, actually. At least that's the case for all the others "shm-" ones.

Copy link
Member

@ktf ktf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need the parameter to be propagated in a few more places, like the others.

@justonedev1
Copy link
Collaborator Author

Is this better @ktf ?

@alibuild
Copy link
Collaborator

Error while checking build/O2/fullCI for 7ed0eab at 2024-03-12 17:07:

## sw/BUILD/O2-latest/log
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'


## sw/BUILD/O2-full-system-test-latest/log
task timeout reached .. killing all processes


## sw/BUILD/o2checkcode-latest/log
--
========== List of errors found ==========
++ GRERR=0
++ grep -v clang-diagnostic-error error-log.txt
++ grep ' error:'
++ GRERR=1
++ [[ 1 == 0 ]]
++ mkdir -p /sw/INSTALLROOT/d72b37390585d526cf80cd9a7a7fa7ab0e67c575/slc8_x86-64/o2checkcode/1.0-local212/etc/modulefiles
++ cat
--

Full log here.

@justonedev1
Copy link
Collaborator Author

@ktf I removed the logging lines and rebased it on current dev branch so CI works. Is there anything else I need to change?

@knopers8
Copy link
Collaborator

@ktf ping

1 similar comment
@justonedev1
Copy link
Collaborator Author

@ktf ping

@ktf ktf merged commit 94be5fc into AliceO2Group:dev Mar 19, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants