Hotfix for PID Hypothesis - switch to disable Canvas #12755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 14 commits
January 31, 2024 15:08
HorstMa
requested review from
davidrohr,
wiechula and
shahor02
as code owners
|
Error while checking build/O2/fullCI for 0a28b53 at 2024-02-23 22:45: Full log here. |
wiechula
requested changes
Feb 26, 2024
wiechula
requested changes
Feb 26, 2024
|
thanks, @wiechula I changed the naming convention and added a separate function. |
wiechula
approved these changes
Feb 28, 2024
|
Can be merged from my side, but should be squashed. The failure looks unrelated. |
andreasmolander
pushed a commit
to andreasmolander/AliceO2
that referenced
this pull request
Apr 12, 2024
) * Adding PID Hypothesis for PID Task * Updated GetMostProbablePID * formatting * formatting 2 * formatting3 * formatting4 * added recommendations * fromatting * cleanup * change runPID macro with new processTrack * Added dummy processTrack to be compatible with QC * Hotfix for PID Hypothesis to disable TCanvas generation * quickfix * Formatting * naming Convention, added separate function for setCreateCanvas --------- Co-authored-by: Maximilian Horst <[email protected]>
andreasmolander
pushed a commit
to andreasmolander/AliceO2
that referenced
this pull request
Apr 12, 2024
) * Adding PID Hypothesis for PID Task * Updated GetMostProbablePID * formatting * formatting 2 * formatting3 * formatting4 * added recommendations * fromatting * cleanup * change runPID macro with new processTrack * Added dummy processTrack to be compatible with QC * Hotfix for PID Hypothesis to disable TCanvas generation * quickfix * Formatting * naming Convention, added separate function for setCreateCanvas --------- Co-authored-by: Maximilian Horst <[email protected]>
mwinn2
pushed a commit
to mwinn2/AliceO2
that referenced
this pull request
Apr 25, 2024
) * Adding PID Hypothesis for PID Task * Updated GetMostProbablePID * formatting * formatting 2 * formatting3 * formatting4 * added recommendations * fromatting * cleanup * change runPID macro with new processTrack * Added dummy processTrack to be compatible with QC * Hotfix for PID Hypothesis to disable TCanvas generation * quickfix * Formatting * naming Convention, added separate function for setCreateCanvas --------- Co-authored-by: Maximilian Horst <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an issue with the last PR #12630 where TCanvas could not be merged. This PR allows to disable the TCanvas generation through the JSON file. This is paired with another PR in QC (AliceO2Group/QualityControl#2151).