Skip to content

Commit

Permalink
[go] reversion sdk47 aar with unwinder fix (expo#21604)
Browse files Browse the repository at this point in the history
# Why

fix android expo go when loading sdk 47 project on android 10

# How

the crash reason is `couldn't find DSO to load: libjscexecutor_abi47_0_0.so caused by: dlopen failed: cannot locate symbol "_Unwind_Resume" referenced by "/data/app/host.exp.exponent-Sd4bXgd0_2W05EULOnhTZw==/lib/arm64/libjscexecutor_abi47_0_0.so"... result: 0` which is a ndk r23 issue where we should also link jsc with libunwinder explicitly.

besides building the sdk 47 versioned aar, we should also link the libunwinder as facebook/react-native@a232dec#diff-56e69cdb1f3a7a0b6a6f5aa63552e0bfa203512e588eaa0387449c4e43b315deR16-R27

i also update those ndk r21 libs in this pr, including:
- libexpo-modules-core.so
- libexpo-av.so
- libexpo-gl.co
- libreanimated.so
- libreactnativeskia.so

# Test Plan

- android expo go + sdk 46/47/48 projects
- android expo go + sdk 48 ncl
- android expo go + sdk 47 + android 10 emulator

check ndk
```
1. unzip /path/to/apk
2. for f in */*/*.so; do ndk=`/path/to/parse_elfnote.py $f | grep NDK_VERSION`; echo "${f} ${ndk}"; done | grep r21
3. nm -CD */*/*.so | grep Unwind_Resume
```
  • Loading branch information
Kudo authored Mar 8, 2023
1 parent cc3a274 commit 9e54eac
Show file tree
Hide file tree
Showing 43 changed files with 2 additions and 2 deletions.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#NOTE: This is a Maven Resolver internal implementation file, its format can be changed without prior notice.
#Tue Feb 28 12:06:16 CST 2023
#Wed Mar 08 12:51:14 CST 2023
reactandroid-abi47_0_0-1.0.0.pom>=
reactandroid-abi47_0_0-1.0.0.aar>=
Binary file not shown.
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,6 @@
<versions>
<version>1.0.0</version>
</versions>
<lastUpdated>20230228040616</lastUpdated>
<lastUpdated>20230308045114</lastUpdated>
</versioning>
</metadata>
Loading

0 comments on commit 9e54eac

Please sign in to comment.