Skip to content

Commit

Permalink
partial revert: [templates] Remove config options that don't apply to…
Browse files Browse the repository at this point in the history
… templates (expo#21273)

# Why

This partially reverts ff9831c since
there are still tools that rely upon this:
https://github.com/expo/expo/blob/main/packages/%40expo/cli/src/export/exportAssets.ts#L19

This will need to be cherry-picked into 48 since somehow the blame rev
got in there.

# How

Revert portion of it.

# Test Plan

inspect

# Checklist

<!--
Please check the appropriate items below if they apply to your diff.
This is required for changes to Expo modules.
-->

- [ ] Documentation is up to date to reflect these changes (eg:
https://docs.expo.dev and README.md).
- [ ] Conforms with the [Documentation Writing Style
Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
- [ ] This diff will work correctly for `expo prebuild` & EAS Build (eg:
updated a module plugin).
  • Loading branch information
wschurman authored Feb 17, 2023
1 parent 225bf8f commit 037c421
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 1 deletion.
3 changes: 2 additions & 1 deletion templates/expo-template-bare-minimum/app.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
"expo": {
"name": "HelloWorld",
"slug": "expo-template-bare",
"version": "1.0.0"
"version": "1.0.0",
"assetBundlePatterns": ["**/*"]
}
}
1 change: 1 addition & 0 deletions templates/expo-template-blank-typescript/app.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
"resizeMode": "contain",
"backgroundColor": "#ffffff"
},
"assetBundlePatterns": ["**/*"],
"ios": {
"supportsTablet": true
},
Expand Down
1 change: 1 addition & 0 deletions templates/expo-template-blank/app.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
"resizeMode": "contain",
"backgroundColor": "#ffffff"
},
"assetBundlePatterns": ["**/*"],
"ios": {
"supportsTablet": true
},
Expand Down
1 change: 1 addition & 0 deletions templates/expo-template-tabs/app.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
"resizeMode": "contain",
"backgroundColor": "#ffffff"
},
"assetBundlePatterns": ["**/*"],
"ios": {
"supportsTablet": true
},
Expand Down

0 comments on commit 037c421

Please sign in to comment.