Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Another approach to the index.html and index.js #822

Merged
merged 5 commits into from
Nov 27, 2024

Conversation

fridrich
Copy link
Contributor

@fridrich fridrich commented Nov 6, 2024

This commit is basically compiling the index.html and index.js as resources into the binary. It avoids one to have to install them and bother about finding where they are.

@fridrich
Copy link
Contributor Author

fridrich commented Nov 6, 2024

Now, this would need the xxd resource compiler, but I find that the advantage of having a single binary is great

@AlbrechtL AlbrechtL requested a review from mpbraendli November 9, 2024 18:41
@mpbraendli
Copy link
Collaborator

Hi, I like the idea, even though for development it means changing the HTML incurrs a compile/link cycle, and it makes user-customisation more difficult. But it avoids file availability issues.

Why did you move from C++17 to C++14?

Using xxd -i is cool, I was wondering if we could use od instead, because that's in coreutils, but it'd need more tinkering. So I'm ok with adding xxd as a build-time dependency.

@fridrich
Copy link
Contributor Author

I moved the C++17 back to the C++14 because originally in the reverted commit I added it only to be able to use std::filesystem::path which is now not needed again. That is why I also restored lower cmake requirement

@fridrich
Copy link
Contributor Author

Ping?

@mpbraendli
Copy link
Collaborator

Thanks for the reminder!

@mpbraendli mpbraendli merged commit 6fcccb5 into AlbrechtL:next Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants