Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the purpose of this commit was to change the behaviour of the SLS but… #800

Closed
wants to merge 1 commit into from
Closed

Conversation

davidea72
Copy link

…ton, before, if clicked it shows the SLS, but when a new SLS arrive we continue to show

the old, we must click on the close button and reopen it i use it on my car and it was very annoying, the i change the behaviour to update the SLS image without human interaction to do this i change the html and javascript code
secondary, on the deck of my car the button are too small, i enlarge it

on the web page (index.html) i change the font size of the button, from 7 to 12 px to better click it i change the transparency of the .slide-modal from 0.9 to 0.1 to make readeable the underneath layer

on the javascript (index.js) i declare a new global variable var show=0;

in

function showSlide(sid, last_update_time) i add

show=last_update_time;
console.log(slideimg.src)

to track the last update date for the use below

slideclose.onclick

show=0; to clear the variable when we close the SLS

in the

function populateEnsembleinfo()

i add

        if (service.mot.time>show && show ) {
            var tempo = service.mot.time;
            showSlide(parseInt(service.sid), service.mot.time);
    }

to check if a new SLS was arrived and to recall the showSlide function to update the image

What does this PR do and why is it necessary?

How was it tested? How can it be tested by the reviewer?

Any background context you want to provide?

What are the relevant tickets if any?

Screenshots (if appropriate)

Further notes

…ton, before, if clicked it shows the SLS, but when a new SLS arrive we continue to show

the old, we must click on the close button and reopen it
i use it on my car and it was very annoying, the i change the behaviour to update the SLS image without human interaction
to do this i change the html and javascript code
secondary, on the deck of my car the button are too small, i enlarge it

on the web page (index.html) i change the font size of the button, from 7 to 12 px to better click it
i change the transparency of the .slide-modal from 0.9 to 0.1 to make readeable the underneath layer

on the javascript (index.js) i declare a new global variable
var show=0;

in

function showSlide(sid, last_update_time) i add

show=last_update_time;
console.log(slideimg.src)

to track the last update date for the use below

slideclose.onclick

show=0; to clear the variable when we close the SLS

in the

function populateEnsembleinfo()

i add

            if (service.mot.time>show && show ) {
                var tempo = service.mot.time;
                showSlide(parseInt(service.sid), service.mot.time);
        }

to check if a new SLS was arrived and to recall the showSlide function to update the image
@andimik
Copy link
Contributor

andimik commented Feb 21, 2024

Can you post a screenshot how it will look then?

Copy link
Owner

@AlbrechtL AlbrechtL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your pull request.

Please do us the favor use the next branch, please. Afterwards we will review your PR.

@davidea72 davidea72 closed this by deleting the head repository Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants