welle-cli: disable software AGC in manual gain mode #780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manually selecting gain via '-g' parameter does not disable software AGC. This change fixes that.
During initial connection to server, gain cannot be properly set before firstData is received. This change moves RTL gain initialization after device detection.
kkubicki
force-pushed
the
kkubicki-disable-sw-agc
branch
from
f5a215d to
81dfcbd
Compare
|
Thanks, sorry for taking a bit long to accept the pull request! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do and why is it necessary?
It disables software AGC when using manual gain setting.
How was it tested? How can it be tested by the reviewer?
Tested with rtl_tcp + passing '-g' parameter (0..28 in case of RTL820T) and observing 'RX gain' in web view.
Both '-g -1' & no '-g' parameter passed enables software AGC again.