undid #740 #767
Merged
undid #740 #767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mpbraendli Can you review this PR, please? |
mpbraendli
approved these changes
Dec 14, 2022
|
Ok, this initial effort wasn't yet conclusive, but I hope the next one will be! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do and why is it necessary?
As concluded in #748,
#740 was supposed to be undone.
From what I can tell,
@rocus did not yet file a PR to undo the changes,
so I decided to so in order for the
nextbranch to be working(See #742).
How was it tested? How can it be tested by the reviewer?
As I no longer have an antenna, I was unable to do real tests.
But given that this commit basically undid #740 (I used the patch file)
it should be working exactly the same as before.
Any background context you want to provide?
I was unable to fix the segfault,
as discussed in #742.
And thus failed to make the feature function properly
(the cli crashed after a client disconnected)
What are the relevant tickets if any?
#740 , #742 , #748 , #738 , #741
Further notes
I did not add the changes proposed by @rocus in #748.
But I thought that undoing my PR,
might make pushing theirs easier.
And I'm not sure if I undid everything – but from what I can tell it was the only merged PR I did.