Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test for class_optimize in PR #88 #98

Merged
merged 1 commit into from
Oct 5, 2024
Merged

Conversation

NormannK
Copy link
Collaborator

@NormannK NormannK commented Oct 4, 2024

Test meant for class_optimize.
Will only work with PR #88 since the old class has no way to use a fixed random seed.

To use it on the old/current class add random.seed(42) to the init of optimization_problem and add fixed_seed=None as a possible argument.

pre-commit style of the lists and dicts does look odd.
It takes quite a while to finish also there are two warnings from the visualization class.
Suggestions are appreciated.

@NormannK NormannK mentioned this pull request Oct 4, 2024
@danimo
Copy link
Collaborator

danimo commented Oct 4, 2024

can you fold this into #88 then?

@NormannK
Copy link
Collaborator Author

NormannK commented Oct 4, 2024

Sure I can, but im not so sure its the right way to do it. If you say its the proper way to do it id be happy to do so.

@danimo
Copy link
Collaborator

danimo commented Oct 4, 2024

Well if the test doesn't work prior to #88, but tests #88, then it should go with #88. Maybe also rebase #88 on top of main if you know how to do so.

@NormannK
Copy link
Collaborator Author

NormannK commented Oct 5, 2024

Well if the test doesn't work prior to #88, but tests #88, then it should go with #88. Maybe also rebase #88 on top of main if you know how to do so.

merged thanks! ill send this in to review

@NormannK NormannK marked this pull request as ready for review October 5, 2024 07:48
@drbacke
Copy link
Collaborator

drbacke commented Oct 5, 2024

Please merge this into the newest code, the "wechselrichter" bug is already resolved.

@michaelosthege
Copy link
Collaborator

michaelosthege commented Oct 5, 2024

that'll be

git fetch origin
git rebase origin/main

then resolve conflicts

git rebase --continue
git push -f

Test meant for class_optimize.
Will only work with PR #88 since the old class has no way to use a fixed random seed.
@NormannK
Copy link
Collaborator Author

NormannK commented Oct 5, 2024

thank you very much @michaelosthege I just redid my whole setup and learned a lot. i should go more smooth in the future (fingers crossed)

@NormannK NormannK force-pushed the patch-5 branch 2 times, most recently from 91206f9 to cab16bf Compare October 5, 2024 11:39
@danimo danimo merged commit d4080f3 into Akkudoktor-EOS:main Oct 5, 2024
4 checks passed
@NormannK NormannK deleted the patch-5 branch October 5, 2024 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants