Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multi-arch container build #83

Merged
merged 1 commit into from
Oct 5, 2024

Conversation

ss89
Copy link

@ss89 ss89 commented Oct 3, 2024

In this PR I have adjusted the dockerfile a bit, to retain some disk space.
This is the part where I am the most uncertain if I broke something, as I am not running EOS my own and just getting into the project a bit.
I did see that upon uninstalling unused packages it did uninstall the mysql/mariadb libraries, so I re-added those by tagging them as manually installed.

Also I added multi arch container image building upon release creation which then push to the github container registry and allow easier distribution of the software for docker/containerd/k8s users.

Let me know what you think or what needs adjustments to work well.

@ss89
Copy link
Author

ss89 commented Oct 3, 2024

Currently I do get this error message from python, however I am not a python guy and unsure how to resolve it:

Traceback (most recent call last):
2024-10-03T17:34:10.780518675Z   File "/opt/eos/flask_server.py", line 19, in <module>
2024-10-03T17:34:10.780521008Z     from modules.class_optimize import isfloat, optimization_problem
2024-10-03T17:34:10.780522300Z   File "/opt/eos/modules/class_optimize.py", line 8, in <module>
2024-10-03T17:34:10.780523633Z     from modules.class_ems import EnergieManagementSystem, Wechselrichter
2024-10-03T17:34:10.780524716Z ImportError: cannot import name 'Wechselrichter' from 'modules.class_ems' (/opt/eos/modules/class_ems.py)

@ss89 ss89 force-pushed the add-github-docker-build branch 2 times, most recently from 4bf5299 to 0110b50 Compare October 4, 2024 11:50
@ss89
Copy link
Author

ss89 commented Oct 4, 2024

Fixes the trace by importing Wechselrichter from class_inverter instead of class_ems

@NormannK
Copy link
Collaborator

NormannK commented Oct 4, 2024

Fixes the trace by importing Wechselrichter from class_inverter instead of class_ems

i did fix that in my PR #88

@ss89
Copy link
Author

ss89 commented Oct 4, 2024

Fixes the trace by importing Wechselrichter from class_inverter instead of class_ems

i did fix that in my PR #88

Nice, i did not read through all the Forks and changes.
There's too much work going on concurrently and I'm super new to the project.
Shouldn't be hard to fixup if needed after either of our PRs got merged 👍🏻

@ss89 ss89 force-pushed the add-github-docker-build branch from 0110b50 to 31be9d5 Compare October 4, 2024 16:31
@ss89
Copy link
Author

ss89 commented Oct 4, 2024

@drbacke mind checking this out?

@drbacke drbacke merged commit 9ae5796 into Akkudoktor-EOS:main Oct 5, 2024
2 checks passed
@ss89 ss89 deleted the add-github-docker-build branch October 5, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants