Fix test_server Closes #147 #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Lasall
commented
Oct 9, 2024
Lasall
commented
- Don´t rely on calculation per specific day. For now we can assume 48 values (2 days prediction).
Lasall
force-pushed
the
dl_dev-fix-test-server
branch
2 times, most recently
from
1b00d05 to
fb04701
Compare
b0661
reviewed
Oct 9, 2024
tests/test_server.py
Outdated
| ] | ||
| """ | ||
| ) | ||
| assert len(json.loads(result.text)) == prediction_hours |
There was a problem hiding this comment.
You may use
assert len(result.json()) == prediction_hours* Don´t rely on calculation per specific day, just verify length.
Lasall
force-pushed
the
dl_dev-fix-test-server
branch
from
fb04701 to
f7c97ac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.