Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(fast-usdc): beta oracle addresses #10996

Merged
merged 4 commits into from
Feb 13, 2025
Merged

chore(fast-usdc): beta oracle addresses #10996

merged 4 commits into from
Feb 13, 2025

Conversation

dckc
Copy link
Member

@dckc dckc commented Feb 12, 2025

refs: #10978

Description

Update OCW addrs

assetInfo need not vary across configurations, so no more "default".

Security Considerations

Production key management considerations apply.

Scaling Considerations

n/a

Documentation Considerations

The addresses of the operators are perhaps worth sharing in the community governance thread.

Testing Considerations

DRY out referenced to old oracle addrs in a test.

Upgrade Considerations

not yet deployed

@dckc dckc requested a review from a team as a code owner February 12, 2025 21:18
@dckc dckc requested a review from AgoricTriage February 12, 2025 21:18
@dckc dckc added the force:integration Force integration tests to run on PR label Feb 12, 2025
Copy link

cloudflare-workers-and-pages bot commented Feb 12, 2025

Deploying agoric-sdk with  Cloudflare Pages  Cloudflare Pages

Latest commit: ce41d7a
Status: ✅  Deploy successful!
Preview URL: https://553f6df2.agoric-sdk.pages.dev
Branch Preview URL: https://dc-fu-beta.agoric-sdk.pages.dev

View logs

@@ -80,10 +79,11 @@ export const configurations = {
assetInfo: agoricAssetInfo,
},
MAINNET: {
// per JVC 12 Feb 2025
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

confirmed

- limit assetInfo in proposal to mimic rest of of test (just usdc on agoric)
Copy link
Member

@0xpatrickdev 0xpatrickdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. The current CI flake is not appearing when running locally.

Please cherry-pick 07c49fd so we also have the same assetInfo subset in multichain-testing (this is what I tested against, btw)

@dckc dckc added the automerge:rebase Automatically rebase updates, then merge label Feb 13, 2025
@mergify mergify bot merged commit 0303d15 into master Feb 13, 2025
93 checks passed
@mergify mergify bot deleted the dc-fu-beta branch February 13, 2025 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge:rebase Automatically rebase updates, then merge force:integration Force integration tests to run on PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants