Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(internal): Disable tsconfig suppressions #10981

Merged
merged 2 commits into from
Feb 11, 2025

Conversation

gibson042
Copy link
Member

Description

There's a note in the tsconfig.json for package "internal" implying that @endo/init requires noImplicitAny, but removing the special casing now seems to work (and removing "checkJs": false caught some TS issues).

@gibson042 gibson042 requested a review from a team as a code owner February 11, 2025 02:28
Copy link

cloudflare-workers-and-pages bot commented Feb 11, 2025

Deploying agoric-sdk with  Cloudflare Pages  Cloudflare Pages

Latest commit: 3c97363
Status: ✅  Deploy successful!
Preview URL: https://2f6dd3f4.agoric-sdk.pages.dev
Branch Preview URL: https://gibson-2025-02-internal-tsco.agoric-sdk.pages.dev

View logs

Copy link
Member

@turadg turadg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Onward

@gibson042 gibson042 added the automerge:squash Automatically squash merge label Feb 11, 2025
@mergify mergify bot merged commit acbb5da into master Feb 11, 2025
83 checks passed
@mergify mergify bot deleted the gibson-2025-02-internal-tsconfig branch February 11, 2025 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge:squash Automatically squash merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants