ci: remove DD metrics reporting from CI

[mujahidkay]

Apparently, our contract with DD run till September. Pending confirmation, this PR will remain draft. Integration test and benchmark results DO NOT get reported GCP right now. Ideally, we should only merge this when we handle these two but not a hard requirement IMO.

closes: ticket

Description

Removes all Datadog related integration for reporting unit test metrics. Also removes additional helper scripts. We are not removing integration test and benchmark test metric reporting right now - that will be done once those metrics are exported to GCP.

Security Considerations

None

Scaling Considerations

None

Documentation Considerations

Its CI only so None

Testing Considerations

all CI.

Upgrade Considerations

None

[cloudflare-workers-and-pages]

Deploying agoric-sdk with    Cloudflare Pages

Latest commit:	8f903f6
Status:	✅  Deploy successful!
Preview URL:	https://445a3363.agoric-sdk.pages.dev
Branch Preview URL:	https://mk-dd-removal.agoric-sdk.pages.dev

View logs

[Muneeb147]

all CI. Like mentioned in the description, in its current state, we will miss out on benchmark and integration test result metrics because our existing gcp CI reporting script doesn't handle these two cases.

@mujahidkay Do have any engineering issue for it as DD sunset follow-up? Also do you think if it is doable as quick-win then we can sync and work on sending the stats first before stopping the DD reporting.
Test metrics which are currently reported to GCP can be removed from datadog.

@frazarshad Thoughts?

[mujahidkay]

all CI. Like mentioned in the description, in its current state, we will miss out on benchmark and integration test result metrics because our existing gcp CI reporting script doesn't handle these two cases.

@mujahidkay Do have any engineering issue for it as DD sunset follow-up? Also do you think if it is doable as quick-win then we can sync and work on sending the stats first before stopping the DD reporting. Test metrics which are currently reported to GCP can be removed from datadog.

@frazarshad Thoughts?

@Muneeb147 I'm not certain how quick of a win would those be. I'm in favor of benching this PR altogether till we port those metrics to GCP (no harm done AFAIK as our contract runs till September) and hopefully we can get this done in a sprint.
I'm also not opposed to your call of removing everything but integration and benchmark reporting so let's make a call on it, and move forward

[Muneeb147]

@mujahidkay Won't it stop reporting of integration and benchmarking too?

[mujahidkay]

This step is used to collect info from individual packages' unit tests via collect-testruns.sh which further converts ava output to a junit format. And each package's junit xml is then exported to DD via

timeout 30 npx @datadog/datadog-ci junit upload --service agoric-sdk ./packages/*/junit.xml

I don't understand why this needs to be done in test-docker-build step. The info is already being sent when we run test-all-packages. On the other hand, benchmarking uses a completely different action which I have kept as is.

[mujahidkay]

That being said, would appreciate a second set of eyes on this. Maybe @usmanmani1122 👀

[turadg]

To close out https://github.com/Agoric/product-tasks/issues/236 I think also requires,

• remove patches/ava+5.3.1.patch that fed timing data to these scripts
• remove dd-trace dep from agoric-cli
• (possibly) remove datadog-go dep from golang/cosmos