Don't translate provided methods that we don't use #540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nadrieril
force-pushed
the
lazy-translate-methods
branch
from
91756fe to
9d7c40a
Compare
This was referenced Jan 30, 2025
Nadrieril
force-pushed
the
lazy-translate-methods
branch
2 times, most recently
from
0ba4770 to
d3c9ee1
Compare
Nadrieril
force-pushed
the
lazy-translate-methods
branch
from
d3c9ee1 to
ab69275
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces the size of charon's output by giving a new meaning to opacity on traits/impls: now, an opaque trait/impl will not have its provided methods (those with a default body) translated, unless they are used. This removes significant churn when translating the
Iteratortrait, among others.This behavior can be turned off with the
--translate-all-methodsflag.